Mike, Laszlo, Jiaxin, I think everything is clear now, thanks for explanations! I will produce a v2 of the patch with updated email address and role. We'll keep 2 maintainers for NetworkPkg for the time being.
Thanks! Maciej -----Original Message----- From: Kinney, Michael D <michael.d.kin...@intel.com> Sent: Tuesday, December 10, 2019 19:28 To: devel@edk2.groups.io; ler...@redhat.com; Rabeda, Maciej <maciej.rab...@intel.com>; Wu, Jiaxin <jiaxin...@intel.com>; Maciej Rabeda <maciej.rab...@linux.intel.com>; Gao, Liming <liming....@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com> Cc: Fu, Siyuan <siyuan...@intel.com> Subject: RE: [edk2-devel] [PATCH] Maintainers.txt: Update reviewer email address Hi Maciej, Once a patch review is complete that updates Maintainers.txt with a new maintainer, one of the existing maintainers should submit a PR to get Maintainer.txt updated in edk2/master. In the corner case where none of the existing maintainers are available to submit this PR, one of the stewards can support this PR. At that point, the new maintainer needs to be added to the TianoCore EDK II Maintainers Team so the new maintainer has The ability to set the 'push' label on PRs they want merged into edk2/master. The new maintainer should send an email to the mailing list requesting membership in the TianoCore EDK II Maintainers team. Thanks, Mike > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo > Ersek > Sent: Tuesday, December 10, 2019 10:17 AM > To: Rabeda, Maciej <maciej.rab...@intel.com>; devel@edk2.groups.io; > Wu, Jiaxin <jiaxin...@intel.com>; Maciej Rabeda > <maciej.rab...@linux.intel.com>; Kinney, Michael D > <michael.d.kin...@intel.com>; Gao, Liming <liming....@intel.com> > Cc: Fu, Siyuan <siyuan...@intel.com> > Subject: Re: [edk2-devel] [PATCH] Maintainers.txt: > Update reviewer email address > > On 12/10/19 19:15, Laszlo Ersek wrote: > > On 12/10/19 16:01, Rabeda, Maciej wrote: > >> Laszlo, > >> > >> Thanks for a thorough explanation of the process :) It looks like > >> one extra step for maintainership > transition seems is identified: > >> "However (AIUI), the mergify bot will reject and > close any PR with the "push" label set if the PR was not submitted by > a maintainer in the first place" > >> > >> For maintainer identification process, where does > the mergify bot get the maintainer list from? > > > > I *think* it is represented through membership in the > "tianocore" > > organization on github.com. > > > > https://github.com/orgs/tianocore/people > > > > I'm not sure but I imagine different people could > have different > > permissions associated with them, in this org. > > Seems like there is a subgroup (?) called > "tianocore/edk-ii-maintainers". > > Thanks > Laszlo > > >> Do you know who should I ask to be added to that > list? > > > > If I remember correctly, Mike can manage such > memberships / rights. > > > > Thanks! > > Laszlo > > > > > -------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52098): https://edk2.groups.io/g/devel/message/52098 Mute This Topic: https://groups.io/mt/67501831/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
