I suggest to include <PiPei.h> instead of <Uefi.h>. If so, other Pi definitions are not required to be included.
ReportCpuHobLib module type should be PEIM. Hob can be produced only in PEI phase. Thanks Liming -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chiu, Chasel Sent: 2020年7月21日 8:58 To: Kuo, IanX <ianx....@intel.com>; devel@edk2.groups.io Cc: Lu, James <james...@intel.com>; Kumar, Chandana C <chandana.c.ku...@intel.com>; Prabhala, Varalakshmi A <varalakshmi.a.prabh...@intel.com>; Chaganty, Rangasai V <rangasai.v.chaga...@intel.com> Subject: Re: [edk2-devel] [edk2-platforms] [PATCH v6 1/6] Platform/Intel/MinPlatformPkg: Fix build error Reviewed-by: Chasel Chiu <chasel.c...@intel.com> > -----Original Message----- > From: Kuo, IanX <ianx....@intel.com> > Sent: Tuesday, July 21, 2020 8:35 AM > To: devel@edk2.groups.io > Cc: Lu, James <james...@intel.com>; Kumar, Chandana C > <chandana.c.ku...@intel.com>; Prabhala, Varalakshmi A > <varalakshmi.a.prabh...@intel.com>; Kuo, IanX <ianx....@intel.com>; > Chaganty, Rangasai V <rangasai.v.chaga...@intel.com>; Chiu, Chasel > <chasel.c...@intel.com> > Subject: [edk2-platforms] [PATCH v6 1/6] > Platform/Intel/MinPlatformPkg: Fix build error > > Fix ReportCpuHobLib build error > > Create a Library instance of ReportCpuHobLib from PlatformInitPei driver. > PA bits reported can be overridden by Library instance in Platform. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2674 > > Change-Id: I0cd6ba4eb7231a3a84f080fdce85bbe74eb29eeb > Signed-off-by: IanX Kuo <ianx....@intel.com> > Cc: Sai Chaganty <rangasai.v.chaga...@intel.com> > Cc: Chasel Chiu <chasel.c...@intel.com> > --- > .../PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git > a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/R > e > portCpuHobLib.c > b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/R > e > portCpuHobLib.c > index aa256534..83fc5249 100644 > --- > a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/R > e > portCpuHobLib.c > +++ > b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/R > e > portCpuHobLib.c > @@ -6,7 +6,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > > **/ > > > > -#include <Base.h> > > +#include <Uefi.h> > > +#include <Pi/PiBootMode.h> > > +#include <Pi/PiHob.h> > > +#include <Library/BaseLib.h> > > #include <Library/HobLib.h> > > > > VOID > > -- > 2.26.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62938): https://edk2.groups.io/g/devel/message/62938 Mute This Topic: https://groups.io/mt/75695055/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
