It looks like the emails are still getting mangled: when I "View Source"
in Thunderbird I'm seeing "=" replaced with "=3D" for example.
Could you make sure you've run "py3 BaseTools\Scripts\SetupGit.py" to
configure your edk2 repo? That should also cause a cover letter to be
generated when you run "git format-patch" since I've noticed it's missing.
Also, it looks like the files have UNIX line endings. Could you convert
them to DOS please? It would be nice if you could run the paches through
EDK2 CI either locally
(https://github.com/tianocore/tianocore.github.io/wiki/How-to-Build-With-Stuart)
or by pushing them to a personal GitHub fork and opening a PR. For
example, one issue the ECC tool will likely complain about is the header
guard format:
> +#ifndef EDKII_USB_ETHERNET_PROTOCOL_H
> +#define EDKII_USB_ETHERNET_PROTOCOL_H
While there shouldn't be leading underscrore, there _should_ be a
trailing underscore.
--
Rebecca Cran
On 2/14/23 22:47, Tony Lo (羅金松) via groups.io wrote:
+teams
-----Original Message-----
From: Richard Ho (何明忠) <richar...@ami.com>
Sent: Wednesday, February 15, 2023 1:37 PM
To: devel@edk2.groups.io
Cc: Andrew Fish <af...@apple.com>; Leif Lindholm <quic_llind...@quicinc.com>; Michael D Kinney
<michael.d.kin...@intel.com>; Michael Kubacki <michael.kuba...@microsoft.com>; Zhiguang Liu
<zhiguang....@intel.com>; Liming Gao <gaolim...@byosoft.com.cn>; Tony Lo (羅金松) <ton...@ami.com>
Subject: [PATCH v3 1/3] UsbNetworkPkg/UsbRndis: Add USB RNDIS devices support
This driver provides UEFI driver for USB RNDIS device
Signed-off-by: Richard Ho <richar...@ami.com>
Cc: Andrew Fish <af...@apple.com>
Cc: Leif Lindholm <quic_llind...@quicinc.com>
Cc: Michael D Kinney <michael.d.kin...@intel.com>
Cc: Michael Kubacki <michael.kuba...@microsoft.com>
Cc: Zhiguang Liu <zhiguang....@intel.com>
Cc: Liming Gao <gaolim...@byosoft.com.cn>
Reviewed-by: Tony Lo <ton...@ami.com>
---
UsbNetworkPkg/Config/UsbNetworkPkg.inc.dsc | 9 +
.../Config/UsbNetworkPkgComponentsDxe.inc.dsc | 20 +
.../Config/UsbNetworkPkgComponentsDxe.inc.fdf | 20 +
.../Config/UsbNetworkPkgDefines.inc.dsc | 23 +
.../Protocol/EdkIIUsbEthernetProtocol.h | 877 ++++++++
UsbNetworkPkg/NetworkCommon/ComponentName.c | 263 +++
UsbNetworkPkg/NetworkCommon/DriverBinding.c | 588 ++++++
UsbNetworkPkg/NetworkCommon/DriverBinding.h | 266 +++
UsbNetworkPkg/NetworkCommon/NetworkCommon.inf | 49 +
UsbNetworkPkg/NetworkCommon/PxeFunction.c | 1797 +++++++++++++++++
UsbNetworkPkg/ReadMe.md | 65 +
UsbNetworkPkg/ReleaseNotes.md | 11 +
UsbNetworkPkg/UsbNetworkPkg.dec | 46 +
UsbNetworkPkg/UsbRndis/ComponentName.c | 172 ++
UsbNetworkPkg/UsbRndis/UsbRndis.c | 886 ++++++++
UsbNetworkPkg/UsbRndis/UsbRndis.h | 586 ++++++
UsbNetworkPkg/UsbRndis/UsbRndis.inf | 42 +
UsbNetworkPkg/UsbRndis/UsbRndisFunction.c | 1714 ++++++++++++++++
18 files changed, 7434 insertions(+)
create mode 100644 UsbNetworkPkg/Config/UsbNetworkPkg.inc.dsc
create mode 100644 UsbNetworkPkg/Config/UsbNetworkPkgComponentsDxe.inc.dsc
create mode 100644 UsbNetworkPkg/Config/UsbNetworkPkgComponentsDxe.inc.fdf
create mode 100644 UsbNetworkPkg/Config/UsbNetworkPkgDefines.inc.dsc
create mode 100644 UsbNetworkPkg/Include/Protocol/EdkIIUsbEthernetProtocol.h
create mode 100644 UsbNetworkPkg/NetworkCommon/ComponentName.c
create mode 100644 UsbNetworkPkg/NetworkCommon/DriverBinding.c
create mode 100644 UsbNetworkPkg/NetworkCommon/DriverBinding.h
create mode 100644 UsbNetworkPkg/NetworkCommon/NetworkCommon.inf
create mode 100644 UsbNetworkPkg/NetworkCommon/PxeFunction.c
create mode 100644 UsbNetworkPkg/ReadMe.md
create mode 100644 UsbNetworkPkg/ReleaseNotes.md
create mode 100644 UsbNetworkPkg/UsbNetworkPkg.dec
create mode 100644 UsbNetworkPkg/UsbRndis/ComponentName.c
create mode 100644 UsbNetworkPkg/UsbRndis/UsbRndis.c
create mode 100644 UsbNetworkPkg/UsbRndis/UsbRndis.h
create mode 100644 UsbNetworkPkg/UsbRndis/UsbRndis.inf
create mode 100644 UsbNetworkPkg/UsbRndis/UsbRndisFunction.c
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100244): https://edk2.groups.io/g/devel/message/100244
Mute This Topic: https://groups.io/mt/96977783/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
