On Fri, Feb 24, 2023 at 10:32:26AM +0000, Xie, Yuanhao wrote: > > Hi Gerd, > > -Now you are adding back the AmdSev version. > -It should be the generic version though. > Duplication is as I want to build up the desired functionality in small > steps, generic version is updated in patch3 and ready in patch 6. > > Call AsmRelocateApLoopStartAmdSev brings more confusion.
But now you are adding a duplicate of the AsmRelocateApLoopStartAmdSev function, only to modify it later, which is confusing too ... Maybe the best is this: * Leave asm code unmodified until the generic version is updated. * The patch updating the generic version (#6 in this version) adds the new AP loop as 'AsmRelocateApLoopStartGeneric'. * Finally rename AsmRelocateApLoopStart -> AsmRelocateApLoopStartAmdSev and move to AmdSev.nasm This avoids duplicating the AsmRelocateApLoopStartAmdSev code, making the patches more readable and also shouldn't be confusing due to (temporary) using AsmRelocateApLoopStartAmdSev in the generic code path take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100494): https://edk2.groups.io/g/devel/message/100494 Mute This Topic: https://groups.io/mt/97188907/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
