I'm not really sure why upstream did this. I'll take a look and submit a patch to upstream. Thanks for pointing it out.
On Wed, Nov 2, 2022 at 9:31 PM Fabio Valentini <decatho...@gmail.com> wrote: > On Wed, Nov 2, 2022 at 12:42 PM Ondrej Pohorelsky <opoho...@redhat.com> > wrote: > > > > The missing dependency is pkg-version[0]. It seems like its only outside > dependency is already packaged[1] in Fedora. > > > > It would be great if you could package it. If not, I'll look into it. > > > > > > [0]https://docs.rs/pkg-version/latest/pkg_version/index.html > > [1]https://src.fedoraproject.org/rpms/rust-proc-macro-hack > > I wonder why there need to be two (yes, pkg-version and > pkg-version-impl) libraries just to read three environment variables? > > Are you sure that reading the "CARGO_PKG_VERSION_MAJOR" / > "CARGO_PKG_VERSION_MINOR" / "CARGO_PKG_VERSION_PATCH" environment > variables directly wouldn't be ... easier ... than adding two > additional dependencies? > > I mean, I *can* package these two crates, but they are comically small > (~two dozen lines of code), and their functionality could in most > cases be replaced with single lines of dependency-free Rust code :( > > Fabio > _______________________________________________ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org > Do not reply to spam, report it: > https://pagure.io/fedora-infrastructure/new_issue > -- Ondřej Pohořelský Software Engineer Red Hat <https://www.redhat.com> opoho...@redhat.com <https://www.redhat.com>
_______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
