pwmr has to be set to get the imxfb backlight work, though pwmr was only configurable trough the platform data.
Cc: Rob Herring <rob.herr...@calxeda.com> Cc: Pawel Moll <pawel.m...@arm.com> Cc: Mark Rutland <mark.rutl...@arm.com> Cc: Stephen Warren <swar...@wwwdotorg.org> Cc: Ian Campbell <ijc+devicet...@hellion.org.uk> Cc: devicetree@vger.kernel.org Cc: Jean-Christophe Plagniol-Villard <plagn...@jcrosoft.com> Cc: Tomi Valkeinen <tomi.valkei...@ti.com> Cc: linux-fb...@vger.kernel.org Cc: Sascha Hauer <ker...@pengutronix.de> Cc: linux-arm-ker...@lists.infradead.org Cc: Eric BĂ©nard <e...@eukrea.com> Signed-off-by: Denis Carikli <de...@eukrea.com> Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagn...@jcrosoft.com> Acked-by: Grant Likely <grant.lik...@linaro.org> --- ChangeLog v7->v8: - Added ACKs. --- .../devicetree/bindings/video/fsl,imx-fb.txt | 3 +++ drivers/video/imxfb.c | 2 ++ 2 files changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/video/fsl,imx-fb.txt b/Documentation/devicetree/bindings/video/fsl,imx-fb.txt index 46da08d..ac457ae 100644 --- a/Documentation/devicetree/bindings/video/fsl,imx-fb.txt +++ b/Documentation/devicetree/bindings/video/fsl,imx-fb.txt @@ -17,6 +17,9 @@ Required nodes: Optional properties: - fsl,dmacr: DMA Control Register value. This is optional. By default, the register is not modified as recommended by the datasheet. +- fsl,pwmr: LCDC PWM Contrast Control Register value. That property is + optional, but defining it is necessary to get the backlight working. If that + property is ommited, the register is zeroed. - fsl,lscr1: LCDC Sharp Configuration Register value. Example: diff --git a/drivers/video/imxfb.c b/drivers/video/imxfb.c index 4bf3837..f09372d 100644 --- a/drivers/video/imxfb.c +++ b/drivers/video/imxfb.c @@ -833,6 +833,8 @@ static int imxfb_init_fbinfo(struct platform_device *pdev) of_property_read_u32(np, "fsl,dmacr", &fbi->dmacr); + of_property_read_u32(np, "fsl,pwmr", &fbi->pwmr); + /* These two function pointers could be used by some specific * platforms. */ fbi->lcd_power = NULL; -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html