It'd be easier to give feedback with an inline patch (git send-email).
It seems likely that this closely matches another toolchain, but
needed a slight tweak. Maybe you could point the similar toolchain and
required differences if that is the case?
Why can't you use ARMGCC BUILDRULEFAMILY?
*_WINGCC_*_*_BUILDRULEFAMILY = ARMGCC
Looks like you maybe changed a line unintentionally (or maybe this is
a line ending thing?):
<Command.MSFT, Command.INTEL>
Trim --asl-file -o $(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.i -i
$(INC_LIST) ${src}
"$(ASLPP)" $(ASLPP_FLAGS) $(INC) /I${s_path}
$(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.i >
$(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.iii
- Trim --source-code -l -o
$(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.iiii
$(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.iii
+ Trim --source-code -l -o
$(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.iiii
$(OUTPUT_DIR)(+)${s_dir}(+)${s_base}.iii
Your tools_def comment references MS ASL, which concerned me. Luckily
you seem to be using IASL.
Should tools_def give a bit more detail about "Windows GCC toolchain"?
-Jordan
On Mon, Mar 10, 2014 at 5:59 PM, Olivier Martin <[email protected]> wrote:
> Dear BaseTools maintainers,
>
>
>
> Please find the attached patch that adds support to build EDK2 with GCC
> toolchain on Windows host machine.
>
> The new toolchain is named 'WINGCC'.
>
> It currently only supports ARM and AARCH64 architectures.
>
>
>
> Contributed-under: TianoCore Contribution Agreement 1.0
>
> Signed-off-by: Olivier Martin <[email protected]>
>
> Regards,
>
> Olivier
>
>
> ------------------------------------------------------------------------------
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and their
> applications. Written by three acclaimed leaders in the field,
> this first edition is now available. Download your free book today!
> http://p.sf.net/sfu/13534_NeoTech
> _______________________________________________
> edk2-buildtools-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/edk2-buildtools-devel
>
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech
_______________________________________________
edk2-buildtools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-buildtools-devel
