On 04/21/16 08:57, Ruiyu Ni wrote: > Change the function name to follow new library class > PlatformBootManagerLib interfaces. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ruiyu Ni <ruiyu...@intel.com> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > --- > .../Library/PlatformBootManagerLib/BdsPlatform.c | 42 > ++++++++++------------ > .../Library/PlatformBootManagerLib/BdsPlatform.h | 3 +- > .../PlatformBootManagerLib.inf | 8 ++--- > 3 files changed, 24 insertions(+), 29 deletions(-)
I commented on this patch (in advance) while reviewing patch #5. Beyond those requests, I have one question: > diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c > b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c > index 0bc02ba..53b277d 100644 > --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c > +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c > @@ -1,7 +1,7 @@ > /** @file > Platform BDS customizations. > > - Copyright (c) 2004 - 2014, Intel Corporation. All rights reserved.<BR> > + Copyright (c) 2004 - 2016, Intel Corporation. All rights reserved.<BR> > This program and the accompanying materials > are licensed and made available under the terms and conditions of the BSD > License > which accompanies this distribution. The full text of the license may be > found at > @@ -93,7 +93,7 @@ InstallDevicePathCallback ( > // > VOID > EFIAPI > -PlatformBdsInit ( > +PlatformBootManagerBeforeConsole ( > VOID > ) > /*++ > @@ -111,7 +111,7 @@ Returns: > > --*/ > { > - DEBUG ((EFI_D_INFO, "PlatformBdsInit\n")); > + DEBUG ((EFI_D_INFO, "PlatformBootManagerBeforeConsole\n")); > InstallDevicePathCallback (); > } > > @@ -1207,11 +1207,8 @@ SaveS3BootScript ( > > VOID > EFIAPI > -PlatformBdsPolicyBehavior ( > - IN OUT LIST_ENTRY *DriverOptionList, > - IN OUT LIST_ENTRY *BootOptionList, > - IN PROCESS_CAPSULES ProcessCapsules, > - IN BASEM_MEMORY_TEST BaseMemoryTest > +PlatformBootManagerAfterConsole ( > + VOID > ) > /*++ > > @@ -1221,26 +1218,12 @@ Routine Description: > is driven by boot mode. IBV/OEM can customize this code for their specific > policy action. > > -Arguments: > - > - DriverOptionList - The header of the driver option link list > - > - BootOptionList - The header of the boot option link list > - > - ProcessCapsules - A pointer to ProcessCapsules() > - > - BaseMemoryTest - A pointer to BaseMemoryTest() > - > -Returns: > - > - None. > - > --*/ > { > EFI_STATUS Status; > EFI_BOOT_MODE BootMode; > > - DEBUG ((EFI_D_INFO, "PlatformBdsPolicyBehavior\n")); > + DEBUG ((EFI_D_INFO, "PlatformBootManagerAfterConsole\n")); > > VisitAllInstancesOfProtocol (&gEfiPciRootBridgeIoProtocolGuid, > ConnectRootBridge, NULL); > @@ -1554,6 +1537,19 @@ InstallDevicePathCallback ( > } > > /** > + This function is called each second during the boot manager waits the > timeout. > + > + @param TimeoutRemain The remaining timeout. > +**/ > +VOID > +EFIAPI > +PlatformBootManagerWaitCallback ( > + UINT16 TimeoutRemain > + ) > +{ > +} I located the call to this function in "MdeModulePkg/Universal/BdsDxe/BdsEntry.c", function BdsWait(). Am I correct to think that with MdeModulePkg BDS, we will have no progress bar (unlike with IntelFrameworkModulePkg BDS)? That is, unless we implement one ourselves, in PlatformBootManagerWaitCallback()? If so: I don't think it's a big deal (definitely not a "deal breaker" for this series), but the disappearance of the progress bar should be mentioned in the commit message. The patch looks good otherwise (with my comments in patch #5 addressed). Thanks! Laszlo > + > +/** > Lock the ConsoleIn device in system table. All key > presses will be ignored until the Password is typed in. The only way to > disable the password is to type it in to a ConIn device. > diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h > b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h > index 6ba0d48..cb72596 100644 > --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h > +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h > @@ -1,7 +1,7 @@ > /** @file > Platform BDS customizations include file. > > - Copyright (c) 2006 - 2007, Intel Corporation. All rights reserved.<BR> > + Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR> > This program and the accompanying materials > are licensed and made available under the terms and conditions of the BSD > License > which accompanies this distribution. The full text of the license may be > found at > @@ -40,7 +40,6 @@ Abstract: > #include <Library/PcdLib.h> > #include <Library/PciLib.h> > #include <Library/GenericBdsLib.h> > -#include <Library/PlatformBdsLib.h> > #include <Library/HobLib.h> > #include <Library/UefiLib.h> > #include <Library/DxeServicesTableLib.h> > diff --git > a/OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > b/OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > index 6a04b45..8cbbd12 100644 > --- a/OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > +++ b/OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > @@ -1,7 +1,7 @@ > ## @file > # Platform BDS customizations library. > # > -# Copyright (c) 2007 - 2015, Intel Corporation. All rights reserved.<BR> > +# Copyright (c) 2007 - 2016, Intel Corporation. All rights reserved.<BR> > # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the BSD > License > # which accompanies this distribution. The full text of the license may be > found at > @@ -14,11 +14,11 @@ > > [Defines] > INF_VERSION = 0x00010005 > - BASE_NAME = PlatformBdsLib > - FILE_GUID = F844172E-9985-44f2-BADE-0DD783462E95 > + BASE_NAME = PlatformBootManagerLib > + FILE_GUID = FB65006C-AC9F-4992-AD80-184B2BDBBD83 > MODULE_TYPE = DXE_DRIVER > VERSION_STRING = 1.0 > - LIBRARY_CLASS = PlatformBdsLib|DXE_DRIVER > + LIBRARY_CLASS = PlatformBootManagerLib|DXE_DRIVER > > # > # The following information is for reference only and not required by the > build tools. > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel