Hi, Saoukh

What tool-chain and build option are you using? Are you changing tools_def.txt 
in Conf directory?
Could you paste the entire command line of building this .c file to us?

Thanks
Feng

From: Nikolai Saoukh [mailto:[email protected]]
Sent: Tuesday, January 15, 2013 22:27
To: [email protected]
Subject: [edk2] tautological-constant-out-of-range-compare

This particular case was discussed already

/tiano/edk2/MdeModulePkg/Core/Dxe/Mem/Pool.c:188:49: error: comparison of 
constant 2147483647 with expression of type 'EFI_MEMORY_TYPE' is always true 
[-Werror,-Wtautological-constant-out-of-range-compare]
  if ((PoolType >= EfiMaxMemoryType && PoolType <= 0x7fffffff) ||
                                       ~~~~~~~~ ^  ~~~~~~~~~~

/tiano/edk2/MdeModulePkg/Core/Dxe/Mem/Page.c:528:40: error: comparison of 
constant 2147483647 with expression of type 'EFI_MEMORY_TYPE' is always true 
[-Werror,-Wtautological-constant-out-of-range-compare]
  if (Type >= EfiMaxMemoryType && Type <= 0x7fffffff) {
                                  ~~~~ ^  ~~~~~~~~~~

.................

"i686-pc-mingw32-objcopy" --redefine-sym _memcpy=_CopyMem --redefine-sym 
_memset=_SetMem 
/tiano/edk2/Build/DuetPkgIA32/DEBUG_PECLANG/IA32/MdeModulePkg/Core/Dxe/DxeMain/OUTPUT/Mem/Pool.obj
/tiano/edk2/MdeModulePkg/Core/Dxe/Mem/Page.c:1101:53: error: comparison of 
constant 2147483647 with expression of type 'EFI_MEMORY_TYPE' is always true 
[-Werror,-Wtautological-constant-out-of-range-compare]
  if ((MemoryType >= EfiMaxMemoryType && MemoryType <= 0x7fffffff) ||
                                         ~~~~~~~~~~ ^  ~~~~~~~~~~


I guess it should be written like this

if ((PoolType >= EfiMaxMemoryType && ((UINT32)PoolType <= 0x7fffffff)) ...
------------------------------------------------------------------------------
Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery
and much more. Keep your Java skills current with LearnJavaNow -
200+ hours of step-by-step video tutorials by Java experts.
SALE $49.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122612 
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to