----- Original Message ----- > From: "Moti Asayag" <masa...@redhat.com> > To: "Yair Zaslavsky" <yzasl...@redhat.com> > Cc: "Oved Ourfalli" <ov...@redhat.com>, "Eyal Edri" <ee...@redhat.com>, > "engine-devel" <engine-devel@ovirt.org> > Sent: Thursday, January 2, 2014 11:46:29 AM > Subject: Re: [Engine-devel] IMPORTANT: FindBugs threshold update > > > > ----- Original Message ----- > > From: "Yair Zaslavsky" <yzasl...@redhat.com> > > To: "Moti Asayag" <masa...@redhat.com> > > Cc: "Oved Ourfalli" <ov...@redhat.com>, "Eyal Edri" <ee...@redhat.com>, > > "engine-devel" <engine-devel@ovirt.org> > > Sent: Thursday, January 2, 2014 11:12:17 AM > > Subject: Re: [Engine-devel] IMPORTANT: FindBugs threshold update > > > > > > > > ----- Original Message ----- > > > From: "Moti Asayag" <masa...@redhat.com> > > > To: "Oved Ourfalli" <ov...@redhat.com>, "Eyal Edri" <ee...@redhat.com> > > > Cc: "engine-devel" <engine-devel@ovirt.org> > > > Sent: Thursday, January 2, 2014 12:08:43 AM > > > Subject: Re: [Engine-devel] IMPORTANT: FindBugs threshold update > > > > > > > > > > > > ----- Original Message ----- > > > > From: "Oved Ourfalli" <ov...@redhat.com> > > > > To: "engine-devel" <engine-devel@ovirt.org>, "Allon Mureinik" > > > > <amure...@redhat.com>, "Alissa Bonas" > > > > <abo...@redhat.com> > > > > Sent: Wednesday, January 1, 2014 4:25:50 PM > > > > Subject: [Engine-devel] IMPORTANT: FindBugs threshold update > > > > > > > > Hi all, > > > > > > > > Up until now the jenkins jobs on the gerrit patches included a findbugs > > > > job, > > > > that failed only in case of a warning of level NORMAL or higher. > > > > Now we update this threshold to fail on any findbugs warning, including > > > > LOW > > > > ones. > > > > Moti - > > 1. Aren't use running a local jenkins instance on one of your hosts? Maybe > > Eyal can publish the findbugs job? > > Well...that server is on maintenance for quite a while... > > > 2. What about running the findbugs UI? I find it kinda handy... > > The findbugs UI expects the xml created by findbugs with all of the > violations. > The question is how those violation are created ? where are the rules by > which > findbugs verifies the code (can be findbugs jar or jenkins findbugs plugin or > other...). > > Currently by running 'mvn findbugs:findbugs' i don't get a a single xml > aggregating > all of the violations and the produced ones contain a lot of warnings. > > So I'd like to know how can i be able to run this test locally ?
did you try using eclipse findbugs plugin? http://findbugs.sourceforge.net/manual/eclipse.html i think the most easiest will be is just to check the failures you get on jenkins per patch job. and if there are false positives - report to infra and we'll check and fix. you're missing the aggregate part jenkins findbugs plugin does - http://fpaste.org/65793/09122138/. and i'm not sure if the mvn findbugs plugin has that option on the cli. > > > > > > > > > > > > > > > Could you provide instructions of running findbugs locally and how to > > > evaluate > > > the result the same as done by the jenkins job ? > > > > > > > Please make sure to rebase your current patches and check that the > > > > findbugs > > > > job finish successfully. > > > > It will probably fail without a rebase, as the last patches clearing > > > > the > > > > warnings were merged a few hours ago. > > > > > > > > Kodus to everyone involved in clearing all the LOW level warnings... > > > > mostly > > > > Allon and Alissa, but others helped as well! :-) > > > > > > > > > > Well done! > > > > Great news - good work guys! > > > > > > > > > Cheers, > > > > Oved > > > > _______________________________________________ > > > > Engine-devel mailing list > > > > Engine-devel@ovirt.org > > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > > _______________________________________________ > > > Engine-devel mailing list > > > Engine-devel@ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/engine-devel > > > > > > _______________________________________________ Engine-devel mailing list Engine-devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-devel