Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: tiny pep8 fix ......................................................................
Patch Set 1: Code-Review+1 (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/config/iso_domain.py Line 201: ) Line 202: self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append( Line 203: filetransaction.FileTransaction( Line 204: name=os.path.join(domMdDir, 'leases'), Line 205: content=b'\x00' * 512, not really needed. here we are in a kwarg and space may be omitted. (pep8 doesn't complains at least). However, the pep8 document just say: Don't use spaces around the = sign when used to indicate a keyword argument or a default parameter value. talking only about the '=' so it's fine for me. Line 206: binary=True, Line 207: mode=0o660, Line 208: dmode=0o755, Line 209: owner=self.environment[osetupcons.SystemEnv.USER_VDSM], -- To view, visit http://gerrit.ovirt.org/19459 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If815c86e4978e9b17bd8089086637928cac858fb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
