Greg Padgett has posted comments on this change.
Change subject: Kill the agent if three subsequent broker requests fail
......................................................................
Patch Set 2:
(1 comment)
Logic looks good, just a nit about the wording
....................................................
File ovirt_hosted_engine_ha/agent/hosted_engine.py
Line 252:
Line 253: time.sleep(delay)
Line 254:
Line 255: if error_count >= constants.MAX_ERROR_COUNT:
Line 256: self._log.error("Shutting down the agent because a broker
"
Could be something besides a broker request (vdsm, sanlock, engine actions)
Line 257: "request failed %d times in a row!",
Line 258: constants.MAX_ERROR_COUNT)
Line 259:
Line 260: self._log.debug("Disconnecting from ha-broker")
--
To view, visit http://gerrit.ovirt.org/19294
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5ec6935673133af2e60f339b035dba3438b617f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
