Tomas Jelinek has posted comments on this change. Change subject: webadmin: Changes in disk popup needed to reuse in VM popup ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/36061/11/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AttachDiskModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AttachDiskModel.java: Line 65: new AsyncQuery(this, new GetDisksCallback(DiskStorageType.LUN, prevSelectedDisk), Line 66: getHash()), null, getVm().getId()); Line 67: } Line 68: Line 69: public void loadAttachableDisks(int os, Version compatibilityVersion, final Disk prevSelectedDisk) { > just meant that if this logic is relevant only for instance images then it' right, it is used only from the instance images - extracted to InstanceImagesAttachDiskModel Line 70: // Get internal attachable disks Line 71: AsyncDataProvider.getInstance().getFilteredAttachableDisks( Line 72: new AsyncQuery(this, new GetDisksCallback(DiskStorageType.IMAGE, prevSelectedDisk), Line 73: getHash()), getVm().getStoragePoolId(), getVm().getId(), os, compatibilityVersion); -- To view, visit http://gerrit.ovirt.org/36061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52c5d5c7b83dd53cea3a9419656015e6a51bd179 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Candace Sheremeta <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
