Liron Aravot has posted comments on this change. Change subject: vdsbroker: reduced scope of synchronized blocks ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/37947/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java: Line 155: Line 156: @Override Line 157: protected void executeVDSCommand() { Line 158: boolean isStartReconstruct = false; Line 159: try { > and there's also the failover case. to sum it up, obviously that there is a bottleneck here- we should handle here better at least the spm selection and failover - we need to decide whether we want to handle that issue or wait for 3.6 dc's that'll use different code. it seems to me that we can fix it, but let's wait also for Allons opinion whether he wants it or not. Line 160: if (getIrsProxy() != null) { Line 161: executeIrsBrokerCommand(); Line 162: } else { Line 163: if (getVDSReturnValue().getVdsError() == null) { -- To view, visit https://gerrit.ovirt.org/37947 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d1bfd7b1fc7bfcc6465eae62feda6f1a27ff455 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tim Speetjens <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
