Hello Raster,

I added a small patch for Genlist group item clear.
And I changed git->minh to git->h in item_block_position function.
Thanks Govi

Please review it and let me know if there is any problem in this patch.

Thanks.
Seunggyun Kim

-----Original Message-----
From: Carsten Haitzler (The Rasterman) [mailto:ras...@rasterman.com] 
Sent: Thursday, January 06, 2011 5:59 PM
To: Daniel Juyung Seo
Cc: 'Seunggyun Kim'; manti...@samsung.com;
enlightenment-devel@lists.sourceforge.net
Subject: Re: [E-devel] [Patch] Group index support

On Thu, 06 Jan 2011 14:34:34 +0900 Daniel Juyung Seo
<juyung....@samsung.com>
said:

in svn! :)

> Hello Raster,
> Thanks.
> 
> I added a small patch for Genlist Group.
> I missed one. Thanks Govi!
> Can you review this and apply it to upstream?
> 
> Thanks.
> Daniel Juyung Seo (SeoZ)
> 
> -----Original Message-----
> From: Carsten Haitzler (The Rasterman) [mailto:ras...@rasterman.com] 
> Sent: Thursday, January 06, 2011 2:14 PM
> To: Seunggyun Kim
> Cc: manti...@samsung.com; enlightenment-devel@lists.sourceforge.net
> Subject: Re: [E-devel] [Patch] Group index support
> 
> On Thu, 30 Dec 2010 21:31:40 +0900 Seunggyun Kim <sgyun....@samsung.com>
> said:
> 
> looks ok to me. in svn! :)
> 
> > Hello,
> > 
> > I added group index feature.
> > This feature support to show item indicates group index.
> > I attached capture images showing group index.
> > As you can see attached png images, Group index item includes same group
> > items.
> > 
> > The group index is shown until every items that have same group index
are
> > scrolled.
> > so group index realize/unrealize is not excuteded in
_item_block_position
> > function.
> > instead of the function, group index is controlled in _pan_calculate
> > function.
> > 
> > "Genlist Group" and "Genlist Group Tree" menu is added in
elementary_test.
> > you can test group index operations in elementary_test.
> > 
> > This patch is not support elm_genlist_item_insert_before/after operation
> of
> > group index.
> > We are now considering the operations in group index.,
> > 
> > This patch assumes that the previous 2 patches are already applied to
> > upstream.
> > '[E-devel] [Patch] Tree support for elm_genlist_item_prepend() API.'
> > '[E-devel] [Patch] Tree support for
elm_genlist_item_insert_before/after()
> > APIs',
> > So this patch does not include the changes of the previous patch.
> > 
> > I separated this patch.
> > 
> > - 004.elm_genlist.c.patch.txt
> >     Patch for src/lib/elm_genlist.c
> > - 005.test_genlist.c.patch.txt
> >     Patch for src/bin/test_genlist.c 
> > - 006.genlist.patch.txt
> >     Patch for data/theme/default.edc
> > 
> > And you have to add attached group_index.png file into 'data/themes'
> > 'group_index.png' file is group index background image. 
> > 
> > 
> > Daniel Juyung Seo help make test code and refactoring group index code.
> > 
> > Please review it and let me know if there is any problem in this patch.
> > 
> > Thanks.
> > Seunggyun Kim
> > 
> 
> 
> -- 
> ------------- Codito, ergo sum - "I code, therefore I am" --------------
> The Rasterman (Carsten Haitzler)    ras...@rasterman.com
> 
> 
>
----------------------------------------------------------------------------
> --
> Learn how Oracle Real Application Clusters (RAC) One Node allows customers
> to consolidate database storage, standardize their database environment,
> and, 
> should the need arise, upgrade to a full multi-node Oracle RAC database 
> without downtime or disruption
> http://p.sf.net/sfu/oracle-sfdevnl
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler)    ras...@rasterman.com
Index: src/lib/elm_genlist.c
===================================================================
--- src/lib/elm_genlist.c       (revision 55933)
+++ src/lib/elm_genlist.c       (working copy)
@@ -918,6 +918,8 @@ _item_del(Elm_Genlist_Item *it)
    it->wd->items = eina_inlist_remove(it->wd->items, EINA_INLIST_GET(it));
    if (it->parent)
      it->parent->items = eina_list_remove(it->parent->items, it);
+   if (it->flags & ELM_GENLIST_ITEM_GROUP)
+     it->wd->group_items = eina_list_remove(it->wd->group_items, it);
    if (it->long_timer) ecore_timer_del(it->long_timer);
    if (it->swipe_timer) ecore_timer_del(it->swipe_timer);
 
@@ -2009,7 +2011,7 @@ _item_block_position(Item_Block *itb,
                             if (git->scrl_y < oy)
                                git->scrl_y = oy;
                             if ((git->scrl_y + git->h) > (it->scrl_y + it->h))
-                               git->scrl_y = (it->scrl_y + it->h) - git->minh;
+                               git->scrl_y = (it->scrl_y + it->h) - git->h;
                             git->want_realize = EINA_TRUE;
                          }
                        evas_object_resize(it->base.view, it->w, it->h);
@@ -3123,6 +3125,8 @@ elm_genlist_clear(Evas_Object *obj)
                  (Elm_Genlist_Item *)(EINA_INLIST_GET(it)->prev);
           }
         wd->items = eina_inlist_remove(wd->items, wd->items);
+        if (it->flags & ELM_GENLIST_ITEM_GROUP)
+          it->wd->group_items = eina_list_remove(it->wd->group_items, it);
         elm_widget_item_pre_notify_del(it);
         if (it->realized) _item_unrealize(it);
         if (it->itc->func.del)
------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to