Dear Daniel,
The guidelines don't enforce either way in this case, and putting curly
brackets everywhere is nicer (in my pov) and helps completely preventing
dangling ifs.
--
Tom.
On Thu, 2011-04-21 at 14:05 +0900, Daniel Juyung Seo wrote:
> Hi Tom.
>
> + if (index == 0)
> + {
> + index = evas_common_font_glyph_search(fn, &fi,
> REPLACEMENT_CHAR);
> + }
>
> Why not this?
>
> if (!index)
> index = evas_common_font_glyph_search(fn, &fi, REPLACEMENT_CHAR);
>
> Daniel Juyung Seo (SeoZ)
>
> On Wed, Apr 20, 2011 at 11:20 PM, Enlightenment SVN <
> [email protected]> wrote:
>
> > Log:
> > Evas font-engine: Fix drawing of replacement char when not using Harfbuzz.
> >
> > Author: tasn
> > Date: 2011-04-20 07:20:48 -0700 (Wed, 20 Apr 2011)
> > New Revision: 58755
> > Trac: http://trac.enlightenment.org/e/changeset/58755
> >
> > Modified:
> > trunk/evas/src/lib/engines/common/evas_font_draw.c
> >
> > Modified: trunk/evas/src/lib/engines/common/evas_font_draw.c
> > ===================================================================
> > --- trunk/evas/src/lib/engines/common/evas_font_draw.c 2011-04-20 14:16:51
> > UTC (rev 58754)
> > +++ trunk/evas/src/lib/engines/common/evas_font_draw.c 2011-04-20 14:20:48
> > UTC (rev 58755)
> > @@ -554,6 +554,11 @@
> > index =
> > evas_common_font_glyph_search(fn, &fi,
> > text[EVAS_FONT_WALK_POS]);
> >
> > + if (index == 0)
> > + {
> > + index = evas_common_font_glyph_search(fn, &fi,
> > REPLACEMENT_CHAR);
> > + }
> > +
> > if (fi->src->current_size != fi->size)
> > {
> > FTLOCK();
> >
> >
> >
> > ------------------------------------------------------------------------------
> > Benefiting from Server Virtualization: Beyond Initial Workload
> > Consolidation -- Increasing the use of server virtualization is a top
> > priority.Virtualization can reduce costs, simplify management, and improve
> > application availability and disaster protection. Learn more about boosting
> > the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
> > _______________________________________________
> > enlightenment-svn mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn
> >
> ------------------------------------------------------------------------------
> Benefiting from Server Virtualization: Beyond Initial Workload
> Consolidation -- Increasing the use of server virtualization is a top
> priority.Virtualization can reduce costs, simplify management, and improve
> application availability and disaster protection. Learn more about boosting
> the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
> _______________________________________________
> enlightenment-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
------------------------------------------------------------------------------
Benefiting from Server Virtualization: Beyond Initial Workload
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve
application availability and disaster protection. Learn more about boosting
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
