Hi, EFL developers and Vincent.

On Windows 7, there are some bugs related to key input in elementary_test.
1. alphabet and symbol characters doesn't be inputted in elementary entry.
2. When the space key is pressed, "space" string is entered in elementary
entry.

In this patch, I've tried to fix the above bugs.
It works well when I tested.

Would you please review this patch?

Index: ChangeLog
===================================================================
--- ChangeLog   (revision 64494)
+++ ChangeLog   (working copy)
@@ -307,3 +307,8 @@
         * Port ecore-con to work on systems without IPv6 support
         * Use inet_ntop instead of getnameinfo for ecore_con_client_get_ip
         * Added ecore-con unit test
+
+2011-10-28  Jihoon Kim
+
+        * Ecore_Win32: fix the bug that the key doesn't input and "space" 
string is inserted when space key is pressed.
+
Index: src/lib/ecore_win32/ecore_win32.c
===================================================================
--- src/lib/ecore_win32/ecore_win32.c   (revision 64494)
+++ src/lib/ecore_win32/ecore_win32.c   (working copy)
@@ -86,10 +86,10 @@ _ecore_win32_window_procedure(HWND   window,
        INF("keydown message");
        _ecore_win32_event_handle_key_press(data, 1);
        return 0;
-     /* case WM_CHAR: */
-     /*   INF("char message"); */
-     /*   _ecore_win32_event_handle_key_press(data, 0); */
-     /*   return 0; */
+     case WM_CHAR:
+       INF("char message");
+       _ecore_win32_event_handle_key_press(data, 0);
+       return 0;
      case WM_KEYUP:
        INF("keyup message");
        _ecore_win32_event_handle_key_release(data, 1);
Index: src/lib/ecore_win32/ecore_win32_event.c
===================================================================
--- src/lib/ecore_win32/ecore_win32_event.c     (revision 64494)
+++ src/lib/ecore_win32/ecore_win32_event.c     (working copy)
@@ -798,11 +798,6 @@ _ecore_win32_event_keystroke_get(int    key,
            kc = "KP_Delete";
          }
        break;
-     case VK_SPACE:
-       kn = "space";
-       ks = "space";
-       kc = "space";
-       break;
      case VK_F1:
        kn = "F1";
        ks = "F1";
@@ -992,9 +987,9 @@ _ecore_win32_event_char_get(int    key,
        strncpy(kc, "Escape", 32);
        break;
      case VK_SPACE:
-       strncpy(kn, "space", 32);
-       strncpy(ks, "space", 32);
-       strncpy(kc, "space", 32);
+       strncpy(kn, " ", 32);
+       strncpy(ks, " ", 32);
+       strncpy(kc, " ", 32);
        break;
      default:
        /* displayable characters */

------------------------------------------------------------------------------
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn 
about Cisco certifications, training, and career opportunities. 
http://p.sf.net/sfu/cisco-dev2dev
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to