On Thu, Aug 2, 2012 at 5:42 AM, Enlightenment SVN
<[email protected]> wrote:
> Log:
> fix interactive flip so it works again! :/

I can't test it right now, but based on the following comment it seems
you fixed one case and broke the other:

> +#if 0 // this breaks manual flipping. :/
>          if (sd->state == sd->next_state)
>            {
>               /* it was flipped while flipping, do it again */
> @@ -1282,7 +1287,7 @@
>               sd->state = !sd->next_state;
>               return ECORE_CALLBACK_RENEW;
>            }
> -
> +#endif


Is that right? The case where "it was flipped while flipping" is  now broken?

Also, since you're fixing it and I've complained already about the
mess, what about having clearly separate cases for manual (page) and
automatic flip modes? It's an impossible-to-understand mess at the
moment :-/

-- 
Gustavo Sverzut Barbieri
http://profusion.mobi embedded systems
--------------------------------------
MSN: [email protected]
Skype: gsbarbieri
Mobile: +55 (19) 9225-2202

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to