OK, I reverted the series of diskselector patches. Sorry raster. Instead of adding a new API to change diskselector's default behavior, I will add "item,clicked" smart callback as multibuttonentry does the same thing. This is important to keep the compatibility between widgets.
However, this patch is not a bug fix patch. So it needs to be added after EFL 1.7 release. I guess that's why Shinwoo Kim marked it as since 1.8. It is not a good practice to add a new feature patch. Thanks. Daniel Juyung Seo (SeoZ) On Thu, Aug 30, 2012 at 11:35 AM, Kim Shinwoo <kimcinoo....@gmail.com> wrote: > dear raster, hello > > thanks for your response!!! > but there is a mistake on the previous patch. > > one is on datetime_input_ctxpopup.c, i changed what i did not need to > change. > the other one is visible:0 on diskselector.edc, on auto select disable > state should be visible to emit signal. :-) > > then, check the attachment.. ah.. > > Daniel recommends that it would be better to use smart callback than add > new api which changes default behavior of diskeselector and to keep the > consistency. > > then, please rollback the code or... keep the attachment till revised patch > will be there. > > thanks. > shinwoo kim. > > > 2012/8/29 Carsten Haitzler <ras...@rasterman.com> > >> On Thu, 23 Aug 2012 19:10:16 +0900 Kim Shinwoo <kimcinoo....@gmail.com> >> said: >> >> > by default, an diskselector item which is right in the center of >> > diskselector is selected automatically. >> > and if the item style emit elm,action,click signal, the item is selected >> > also. >> > >> > so there would be a case that item select callback is called by two ways. >> > one is clicking the item, >> > the other is locating item right in the center of diskselector (if number >> > of displayed item is odd, then after scrolling the selected callback is >> > called always). >> > >> > because of this reason, datetime module always set number of displayed >> item >> > to even number. >> > >> > to resolve this issue, i add a api to enable or disable default behavior >> - >> > the auto selection - that can be found on the attachment. >> > moreover the second attachment is for datetime module, now the datetime >> can >> > show even number of items. >> >> find - it fixes a bug, except 1.7 not 1.8 for @since and i think you got >> the >> theme bit wrong so i fixed it to make the auto_select visible: 0 when >> disabled >> and u didnt want to remove the on hold flag ignorer. :) >> >> -- >> ------------- Codito, ergo sum - "I code, therefore I am" -------------- >> The Rasterman (Carsten Haitzler) ras...@rasterman.com >> >> > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
