No, this patch does not do anything useful. I am really sorry but we should not accept this kind of patch.
As far as I know, Myung-jae implemented the feature without adding BLOCK_HANDLE. http://marc.info/?l=enlightenment-devel&w=2&r=1&s=+[Ejde%2C+Elementary]+&q=b But the patch was pending for one and half months due to EFL 1.7 release. So once he resend the patch and if the patch is committed, this kind of hack should be removed. Should I revert this now or leave it and remove it later? I bet we should keep the code clean. Daniel Juyung Seo (SeoZ) On Tue, Aug 28, 2012 at 1:07 AM, Eduardo Lima (Etrunko) <[email protected]> wrote: > Hi Alex, > > Why is this needed? And could you please add the BLOCK_HANDLE entry in > the documentation? > > Best regards, Etrunko. > > On Mon, Aug 27, 2012 at 2:40 AM, <[email protected]> wrote: >> From: Alex Wu <[email protected]> >> >> --- >> trunk/edje/src/bin/edje_cc_handlers.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/trunk/edje/src/bin/edje_cc_handlers.c >> b/trunk/edje/src/bin/edje_cc_handlers.c >> index eb91ed4..b0b2c26 100644 >> --- a/trunk/edje/src/bin/edje_cc_handlers.c >> +++ b/trunk/edje/src/bin/edje_cc_handlers.c >> @@ -3627,6 +3627,7 @@ st_collections_group_parts_part_select_mode(void) >> current_part->select_mode = parse_enum(0, >> "DEFAULT", >> EDJE_ENTRY_SELECTION_MODE_DEFAULT, >> "EXPLICIT", >> EDJE_ENTRY_SELECTION_MODE_EXPLICIT, >> + "BLOCK_HANDLE", >> EDJE_ENTRY_SELECTION_MODE_DEFAULT, >> NULL); >> } >> >> -- >> 1.7.9.5 >> >> >> ------------------------------------------------------------------------------ >> Live Security Virtual Conference >> Exclusive live event will cover all the ways today's security and >> threat landscape has changed and how IT managers can respond. Discussions >> will include endpoint security, mobile security and the latest in malware >> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ >> _______________________________________________ >> enlightenment-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > -- > Eduardo de Barros Lima ◤✠◢ > [email protected] > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
