Some widgets do not have default parts/aliases. It still has to return false if there is no part to handle with. So it depends.
Daniel Juyung Seo (SeoZ) On Fri, Nov 30, 2012 at 3:18 PM, Enlightenment SVN < no-re...@enlightenment.org> wrote: > Log: > [elementary/elm_layout] There can be the cases with no aliases and no part > name. Then EINA_FALSE should be returned. > Should All widgets(including elm_layout) have default aliases? or Not?. > > > > Author: woohyun > Date: 2012-11-29 22:18:48 -0800 (Thu, 29 Nov 2012) > New Revision: 79861 > Trac: http://trac.enlightenment.org/e/changeset/79861 > > Modified: > trunk/elementary/src/bin/test_layout.c > trunk/elementary/src/lib/elm_layout.c > > Modified: trunk/elementary/src/bin/test_layout.c > =================================================================== > --- trunk/elementary/src/bin/test_layout.c 2012-11-30 05:51:04 UTC > (rev 79860) > +++ trunk/elementary/src/bin/test_layout.c 2012-11-30 06:18:48 UTC > (rev 79861) > @@ -50,7 +50,7 @@ > > ly = elm_layout_add(win); > elm_layout_theme_set(ly, "layout", "application", "titlebar"); > - elm_object_text_set(ly, "Some title"); > + elm_object_part_text_set(ly, "elm.text", "Some title"); > evas_object_size_hint_weight_set(ly, EVAS_HINT_EXPAND, > EVAS_HINT_EXPAND); > evas_object_size_hint_align_set(ly, EVAS_HINT_FILL, EVAS_HINT_FILL); > elm_box_pack_end(box, ly); > @@ -83,6 +83,7 @@ > bt = elm_button_add(win); > elm_object_text_set(bt, "Button 2"); > elm_object_part_content_set(ly, "element2", bt); > + //elm_object_part_content_set(ly, NULL, bt); > evas_object_smart_callback_add(bt, "clicked", _clicked_cb, ly); > evas_object_show(bt); > > > Modified: trunk/elementary/src/lib/elm_layout.c > =================================================================== > --- trunk/elementary/src/lib/elm_layout.c 2012-11-30 05:51:04 UTC > (rev 79860) > +++ trunk/elementary/src/lib/elm_layout.c 2012-11-30 06:18:48 UTC > (rev 79861) > @@ -647,9 +647,7 @@ > else > eo_do(sd->obj, elm_obj_layout_smart_content_aliases_get(&aliases)); > > - if (!aliases) return EINA_TRUE; > - > - while (aliases->alias && aliases->real_part) > + while (aliases && aliases->alias && aliases->real_part) > { > /* NULL matches the 1st */ > if ((!*part) || (!strcmp(*part, aliases->alias))) > > > > ------------------------------------------------------------------------------ > Keep yourself connected to Go Parallel: > TUNE You got it built. Now make it sing. Tune shows you how. > http://goparallel.sourceforge.net > _______________________________________________ > enlightenment-svn mailing list > enlightenment-...@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > ------------------------------------------------------------------------------ Keep yourself connected to Go Parallel: TUNE You got it built. Now make it sing. Tune shows you how. http://goparallel.sourceforge.net _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
