Hello cinoo, I have four comments. 1. 'const' for getters. Evas_Object *obj -> const Evas_Object I fixed this in r80369. http://trac.enlightenment.org/e/changeset/80369
2. also const for return values? It returns 'char *' but is there any chance to change this from users? If not, this needs to be 'const char *'. 3. documentations. Can you add descriptions about those access APIs to elm_access.h? 4. samples It will be great if there's any sample/tests in src/examples or src/bin. Daniel Juyung Seo (SeoZ) On Thu, Dec 6, 2012 at 9:21 PM, Enlightenment SVN < [email protected]> wrote: > Log: > [access] add elm_access_external_info_get(Evas_Object*); becuase there is > set(); > > > Author: kimcinoo > Date: 2012-12-06 04:21:19 -0800 (Thu, 06 Dec 2012) > New Revision: 80353 > Trac: http://trac.enlightenment.org/e/changeset/80353 > > Modified: > trunk/elementary/src/lib/elm_access.c > trunk/elementary/src/lib/elm_access.h > > Modified: trunk/elementary/src/lib/elm_access.c > =================================================================== > --- trunk/elementary/src/lib/elm_access.c 2012-12-06 12:18:24 UTC > (rev 80352) > +++ trunk/elementary/src/lib/elm_access.c 2012-12-06 12:21:19 UTC > (rev 80353) > @@ -790,5 +790,14 @@ > (_elm_access_object_get(obj), ELM_ACCESS_EXTERNAL_INFO, text); > } > > +EAPI char * > +elm_access_external_info_get(Evas_Object *obj) > +{ > + Elm_Access_Info *ac; > + > + ac = _elm_access_object_get(obj); > + return _elm_access_text_get(ac, ELM_ACCESS_EXTERNAL_INFO, obj, NULL); > +} > + > EO_DEFINE_CLASS(elm_obj_access_class_get, &class_desc, > ELM_OBJ_WIDGET_CLASS, NULL); > > > Modified: trunk/elementary/src/lib/elm_access.h > =================================================================== > --- trunk/elementary/src/lib/elm_access.h 2012-12-06 12:18:24 UTC > (rev 80352) > +++ trunk/elementary/src/lib/elm_access.h 2012-12-06 12:21:19 UTC > (rev 80353) > @@ -1,5 +1,5 @@ > /** > - * @defgroup Naviframe Naviframe > + * @defgroup Access Access > * @ingroup Elementary > * > * TODO: description > @@ -12,3 +12,6 @@ > > EAPI void > elm_access_external_info_set(Evas_Object *obj, const char *text); > + > +EAPI char * > +elm_access_external_info_get(Evas_Object *obj); > > > > ------------------------------------------------------------------------------ > LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial > Remotely access PCs and mobile devices and provide instant support > Improve your efficiency, and focus on delivering more value-add services > Discover what IT Professionals Know. Rescue delivers > http://p.sf.net/sfu/logmein_12329d2d > _______________________________________________ > enlightenment-svn mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-svn > ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
