cedric pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=725237df0a8b8cab83c8f38368e5d0389dbd196e
commit 725237df0a8b8cab83c8f38368e5d0389dbd196e Author: Cedric Bail <[email protected]> Date: Fri Oct 11 15:15:54 2013 +0900 edje: It should never happen, but apparently it does, so assert to get a proper bt. --- src/lib/edje/edje_signal.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/lib/edje/edje_signal.c b/src/lib/edje/edje_signal.c index 1ccb4fb..1ec9b15 100644 --- a/src/lib/edje/edje_signal.c +++ b/src/lib/edje/edje_signal.c @@ -201,6 +201,7 @@ _edje_signal_callback_push(const Edje_Signal_Callback_Group *cgp, Edje_Signal_Callback_Matches *tmp; tmp = (Edje_Signal_Callback_Matches*) gp->matches; + if (EINA_REFCOUNT_GET(tmp) == 1) { eina_hash_del(signal_match, tmp, tmp); @@ -215,6 +216,8 @@ _edje_signal_callback_push(const Edje_Signal_Callback_Group *cgp, (void) 0; // Nothing to do because the case where refcount == 1 was already handle above. gp->matches = tmp_dup; } + + assert(gp->matches->hashed == 0); } // search an empty spot now @@ -388,7 +391,10 @@ _edje_signal_callback_patterns_ref(const Edje_Signal_Callback_Group *gp) tmp->patterns = NULL; _edje_callbacks_patterns_init((Edje_Signal_Callback_Group*) gp); - eina_hash_add(signal_match, tmp, tmp); + eina_hash_add(signal_match, tmp, tmp); + // We should be able to use direct_add, but if I do so valgrind stack explode and + // it bagain to be a pain to debug efl apps. I can't understand what is going on. + // eina_hash_direct_add(signal_match, tmp, tmp); tmp->hashed = EINA_TRUE; } else --
