But in the commit message he asked if what he did was the right solution, not whether it fixed the build break.
S. > Den Jan 25, 2014 kl. 20:32 skrev Doug Newgard <[email protected]>: > > I wasn't? That was the commit you replied to/quoted, so I thought it was. > > Doug > > ---------------------------------------- >> Date: Sat, 25 Jan 2014 20:29:35 +0100 >> From: [email protected] >> To: [email protected] >> Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary - >> fix the build break. >> >> But that was never the discussion :) >> >> S. >> >> ---- Doug Newgard skrev ---- >> >>> So maybe a new variable is needed. I'm not arguing that cedric's original >>> commit was right or wrong, just that hermit's was right for what was there. >>> >>> Doug >>> >>> ---------------------------------------- >>>> From: [email protected] >>>> Date: Sat, 25 Jan 2014 12:20:34 +0100 >>>> To: [email protected] >>>> Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary - >>>> fix the build break. >>>> >>>> But now elementary version == efl version, which isn't true. efl_version >>>> is used to set elementary's version, and to check the required efl version. >>>> >>>> S. >>>> >>>>> Den Jan 24, 2014 kl. 17:39 skrev Doug Newgard <[email protected]>: >>>>> >>>>> It's right when all of the logic for v_ver was removed and replaced with >>>>> a call to EFL_VERSION, which is what cedric's previous commit did. >>>>> >>>>> ---------------------------------------- >>>>>> Date: Fri, 24 Jan 2014 09:49:56 +0100 >>>>>> From: [email protected] >>>>>> To: [email protected] >>>>>> Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: elementary >>>>>> - fix the build break. >>>>>> >>>>>> This can't be right. efl_version is the required efl version to build >>>>>> elementary, but it doesn't have to be the same as elementary version. >>>>>> >>>>>> S. >>>>>> >>>>>>> On 01/24/2014 03:09 AM, ChunEon Park wrote: >>>>>>> hermet pushed a commit to branch master. >>>>>>> >>>>>>> http://git.enlightenment.org/core/elementary.git/commit/?id=a1ee947fa61e8cdb36b909dd0fd330ff72661f04 >>>>>>> >>>>>>> commit a1ee947fa61e8cdb36b909dd0fd330ff72661f04 >>>>>>> Author: ChunEon Park <[email protected]> >>>>>>> Date: Fri Jan 24 11:07:58 2014 +0900 >>>>>>> >>>>>>> elementary - fix the build break. >>>>>>> >>>>>>> caused by commit 9aa68bca91678dcd83de3e35be1a7121094d6ef7. >>>>>>> >>>>>>> fix please cedric if this is wrong. >>>>>>> --- >>>>>>> configure.ac | 2 +- >>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>>> >>>>>>> diff --git a/configure.ac b/configure.ac >>>>>>> index 4f5215d..e7e6180 100644 >>>>>>> --- a/configure.ac >>>>>>> +++ b/configure.ac >>>>>>> @@ -1,5 +1,5 @@ >>>>>>> EFL_VERSION([1], [8], [99], [dev]) >>>>>>> -AC_INIT([elementary], [v_ver], >>>>>>> [[email protected]]) >>>>>>> +AC_INIT([elementary], [efl_version], >>>>>>> [[email protected]]) >>>>>>> >>>>>>> AC_PREREQ(2.60) >>>>>>> AC_CONFIG_SRCDIR([configure.ac]) >>>>>> >>>>>> >>>>>> ------------------------------------------------------------------------------ >>>>>> CenturyLink Cloud: The Leader in Enterprise Cloud Services. >>>>>> Learn Why More Businesses Are Choosing CenturyLink Cloud For >>>>>> Critical Workloads, Development Environments & Everything In Between. >>>>>> Get a Quote or Start a Free Trial Today. >>>>>> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk >>>>>> _______________________________________________ >>>>>> enlightenment-devel mailing list >>>>>> [email protected] >>>>>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >>>>> ------------------------------------------------------------------------------ >>>>> CenturyLink Cloud: The Leader in Enterprise Cloud Services. >>>>> Learn Why More Businesses Are Choosing CenturyLink Cloud For >>>>> Critical Workloads, Development Environments & Everything In Between. >>>>> Get a Quote or Start a Free Trial Today. >>>>> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk >>>>> _______________________________________________ >>>>> enlightenment-devel mailing list >>>>> [email protected] >>>>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >>>> >>>> ------------------------------------------------------------------------------ >>>> CenturyLink Cloud: The Leader in Enterprise Cloud Services. >>>> Learn Why More Businesses Are Choosing CenturyLink Cloud For >>>> Critical Workloads, Development Environments & Everything In Between. >>>> Get a Quote or Start a Free Trial Today. >>>> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk >>>> _______________________________________________ >>>> enlightenment-devel mailing list >>>> [email protected] >>>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >>> ------------------------------------------------------------------------------ >>> CenturyLink Cloud: The Leader in Enterprise Cloud Services. >>> Learn Why More Businesses Are Choosing CenturyLink Cloud For >>> Critical Workloads, Development Environments & Everything In Between. >>> Get a Quote or Start a Free Trial Today. >>> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk >>> _______________________________________________ >>> enlightenment-devel mailing list >>> [email protected] >>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> ------------------------------------------------------------------------------ >> CenturyLink Cloud: The Leader in Enterprise Cloud Services. >> Learn Why More Businesses Are Choosing CenturyLink Cloud For >> Critical Workloads, Development Environments & Everything In Between. >> Get a Quote or Start a Free Trial Today. >> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk >> _______________________________________________ >> enlightenment-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > ------------------------------------------------------------------------------ > CenturyLink Cloud: The Leader in Enterprise Cloud Services. > Learn Why More Businesses Are Choosing CenturyLink Cloud For > Critical Workloads, Development Environments & Everything In Between. > Get a Quote or Start a Free Trial Today. > http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ CenturyLink Cloud: The Leader in Enterprise Cloud Services. Learn Why More Businesses Are Choosing CenturyLink Cloud For Critical Workloads, Development Environments & Everything In Between. Get a Quote or Start a Free Trial Today. http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
