As requested, here's the patch as an attachement
-- 
Albin

On Sat, Feb 8, 2014 at 1:50 PM, Albin Tonnerre <[email protected]> wrote:
> _op_blend_pan_mas_dp is just a duplication of the code in
> _op_blend_pas_mas_dp. Remove the extra copy of the code and use a define
> instead; this is what the SSE3 code already does.
> ---
> Hi,
>
> I tried submitting that change using 'arc diff' but it keeps crashing because
> of some JSON error, so here goes...
>
>  .../common/evas_op_blend/op_blend_pixel_mask_.c    | 24 
> +---------------------
>  1 file changed, 1 insertion(+), 23 deletions(-)
>
> diff --git a/src/lib/evas/common/evas_op_blend/op_blend_pixel_mask_.c 
> b/src/lib/evas/common/evas_op_blend/op_blend_pixel_mask_.c
> index 5d6c976..78ff716 100644
> --- a/src/lib/evas/common/evas_op_blend/op_blend_pixel_mask_.c
> +++ b/src/lib/evas/common/evas_op_blend/op_blend_pixel_mask_.c
> @@ -48,29 +48,7 @@ _op_blend_pas_mas_dp(DATA32 *s, DATA8 *m, DATA32 c 
> EINA_UNUSED, DATA32 *d, int l
>                       });
>  }
>
> -static void
> -_op_blend_pan_mas_dp(DATA32 *s, DATA8 *m, DATA32 c EINA_UNUSED, DATA32 *d, 
> int l) {
> -   DATA32 *e;
> -   int alpha;
> -   UNROLL8_PLD_WHILE(d, l, e,
> -                     {
> -                        alpha = *m;
> -                        switch(alpha)
> -                          {
> -                          case 0:
> -                             break;
> -                          case 255:
> -                             *d = *s;
> -                             break;
> -                          default:
> -                             alpha++;
> -                             *d = INTERP_256(alpha, *s, *d);
> -                             break;
> -                          }
> -                        m++;  s++;  d++;
> -                     });
> -}
> -
> +#define _op_blend_pan_mas_dp _op_blend_pas_mas_dp
>
>  #define _op_blend_p_mas_dpan _op_blend_p_mas_dp
>  #define _op_blend_pas_mas_dpan _op_blend_pas_mas_dp
> --
> 1.9.rc1
>
From d687e125ce4b83d92ab22937aa5e61ad0139aaa9 Mon Sep 17 00:00:00 2001
From: Albin Tonnerre <[email protected]>
Date: Thu, 6 Feb 2014 20:50:00 +0100
Subject: [PATCH] evas/op_blend: remove duplicated function
 _op_blend_pan_mas_dp

_op_blend_pan_mas_dp is just a duplication of the code in
_op_blend_pas_mas_dp. Remove the extra copy of the code and use a define
instead; this is what the SSE3 code already does.
---
Hi,

I tried submitting that change using 'arc diff' but it keeps crashing because
of some JSON error, so here goes...

 .../common/evas_op_blend/op_blend_pixel_mask_.c    | 24 +---------------------
 1 file changed, 1 insertion(+), 23 deletions(-)

diff --git a/src/lib/evas/common/evas_op_blend/op_blend_pixel_mask_.c b/src/lib/evas/common/evas_op_blend/op_blend_pixel_mask_.c
index 5d6c976..78ff716 100644
--- a/src/lib/evas/common/evas_op_blend/op_blend_pixel_mask_.c
+++ b/src/lib/evas/common/evas_op_blend/op_blend_pixel_mask_.c
@@ -48,29 +48,7 @@ _op_blend_pas_mas_dp(DATA32 *s, DATA8 *m, DATA32 c EINA_UNUSED, DATA32 *d, int l
                      });
 }
 
-static void
-_op_blend_pan_mas_dp(DATA32 *s, DATA8 *m, DATA32 c EINA_UNUSED, DATA32 *d, int l) {
-   DATA32 *e;
-   int alpha;
-   UNROLL8_PLD_WHILE(d, l, e,
-                     {
-                        alpha = *m;
-                        switch(alpha)
-                          {
-                          case 0:
-                             break;
-                          case 255:
-                             *d = *s;
-                             break;
-                          default:
-                             alpha++;
-                             *d = INTERP_256(alpha, *s, *d);
-                             break;
-                          }
-                        m++;  s++;  d++;
-                     });
-}
-
+#define _op_blend_pan_mas_dp _op_blend_pas_mas_dp
 
 #define _op_blend_p_mas_dpan _op_blend_p_mas_dp
 #define _op_blend_pas_mas_dpan _op_blend_pas_mas_dp
-- 
1.9.rc1

------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to