I had asked him to revert it at the time because my git tree was a mess. The issue was that the original commit was wrong. What I had thought was a typo (from quick glance) turned out to be Not a typo and infact was detection for --with-opengl=es ... but yes, the commit msg of the revert could have indicated a reason, sure :)
Dh -----Original Message----- From: Stefan Schmidt [mailto:ste...@datenfreihafen.org] Sent: 17 February 2014 14:01 To: Enlightenment developer list Subject: Re: [E-devel] [EGIT] [core/efl] master 01/01: evas: reverted 9d9ea2e Hello. On Wed, 2014-02-12 at 05:28, Daniel Kolesa wrote: > q66 pushed a commit to branch master. > > http://git.enlightenment.org/core/efl.git/commit/?id=bd7bcad64042742705306a1 92ed27cec9bc1ee59 > > commit bd7bcad64042742705306a192ed27cec9bc1ee59 > Author: Daniel Kolesa <quake...@gmail.com> > Date: Wed Feb 12 13:27:01 2014 +0000 > > evas: reverted 9d9ea2e Looking at the original commit makes me wonder why this got reverted. The commit message does not clarify anything of this. regards Stefan Schmidt > --- > m4/evas_check_engine.m4 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/m4/evas_check_engine.m4 b/m4/evas_check_engine.m4 > index b1e829e..3fd4890 100644 > --- a/m4/evas_check_engine.m4 > +++ b/m4/evas_check_engine.m4 > @@ -554,7 +554,7 @@ have_dep="no" > evas_engine_[]$1[]_cflags="" > evas_engine_[]$1[]_libs="" > > -if test "x${with_opengl}" = "xyes" ; then > +if test "x${with_opengl}" = "xes" ; then > gl_library="glesv2" > else > gl_library="gl" > > -- > > ---------------------------------------------------------------------------- -- Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
