Hello, Stefan. It's just adding enum type used as parameter in edje_object_part_text_input_panel_layout_set (). Therefore, it's complete commit itself. It's not for adding new API or lib(?). If I misunderstood your comment, please let me know. Thanks.
On Friday, February 28, 2014, Stefan Schmidt <[email protected]> wrote: > Hello. > > On Wed, 2014-02-26 at 21:08, Jihoon Kim wrote: > > jihoon pushed a commit to branch master. > > > > > http://git.enlightenment.org/core/efl.git/commit/?id=16f5a5c32325e824af4e67dbe4b593d633e24742 > > > > commit 16f5a5c32325e824af4e67dbe4b593d633e24742 > > Author: Jihoon Kim <[email protected] <javascript:;>> > > Date: Thu Feb 27 14:08:18 2014 +0900 > > > > edje: Add emoticon input panel layout > > --- > > src/lib/edje/Edje_Common.h | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/src/lib/edje/Edje_Common.h b/src/lib/edje/Edje_Common.h > > index 9d83fb5..7180fac 100644 > > --- a/src/lib/edje/Edje_Common.h > > +++ b/src/lib/edje/Edje_Common.h > > @@ -1003,7 +1003,8 @@ typedef enum _Edje_Input_Panel_Layout > > EDJE_INPUT_PANEL_LAYOUT_HEX, /**< Hexadecimal layout > @since 1.2 */ > > EDJE_INPUT_PANEL_LAYOUT_TERMINAL, /**< Command-line terminal > layout including esc, alt, ctrl key, so on (no auto-correct, no > auto-capitalization) @since 1.2 */ > > EDJE_INPUT_PANEL_LAYOUT_PASSWORD, /**< Like normal, but no > auto-correct, no auto-capitalization etc. @since 1.2 */ > > - EDJE_INPUT_PANEL_LAYOUT_DATETIME /**< Date and time layout > @since 1.8 */ > > + EDJE_INPUT_PANEL_LAYOUT_DATETIME, /**< Date and time layout > @since 1.8 */ > > + EDJE_INPUT_PANEL_LAYOUT_EMOTICON /**< Emoticon layout @since > 1.10 */ > > } Edje_Input_Panel_Layout; > > This and the commit before in ecore_imf are only the start for the > emoticon lib, right? Or did I miss anything and we have that in efl > already? > > I would always try to bring in all the pieces together. If, for > whatever reason, the emoticon lib code would not make it for 1.10 its > very likely that we will forget about these two commits which already > advertise it for 1.10. Not really a big deal, but having these two > together with the rest of the code would be better I think. > > regards > Stefan Schmidt > > > ------------------------------------------------------------------------------ > Flow-based real-time traffic analytics software. Cisco certified tool. > Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer > Customize your own dashboards, set traffic alerts and generate reports. > Network behavioral analysis & security monitoring. All-in-one tool. > > http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk > _______________________________________________ > enlightenment-devel mailing list > [email protected] <javascript:;> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Flow-based real-time traffic analytics software. Cisco certified tool. Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer Customize your own dashboards, set traffic alerts and generate reports. Network behavioral analysis & security monitoring. All-in-one tool. http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
