discomfitor pushed a commit to branch master. http://git.enlightenment.org/apps/empc.git/commit/?id=ce69d2d4b610501cabddfcb7fdba1e50f91306c5
commit ce69d2d4b610501cabddfcb7fdba1e50f91306c5 Author: zmike <[email protected]> Date: Tue Dec 16 00:46:45 2014 -0500 fix some probably-impossible-to-trigger uninitialized variable warnings ../src/bin/empc.c: In function 'queue_list_delete_selected': ../src/bin/empc.c:2024:7: warning: 'sub' may be used uninitialized in this function [-Wmaybe-uninitialized] ../src/bin/empdd.c: In function 'main': ../src/bin/empdd.c:1395:19: warning: 'settings' may be used uninitialized in this function [-Wmaybe-uninitialized] ../src/bin/empc.c: In function 'filesystem_item_content_get': ../src/bin/empc.c:1342:42: warning: 'req' may be used uninitialized in this function [-Wmaybe-uninitialized] ../src/bin/empc.c: In function 'empc_status': ../src/bin/empc.c:879:46: warning: 'sop' may be used uninitialized in this function [-Wmaybe-uninitialized] ../src/bin/empc.c:808:26: note: 'sop' was declared here --- src/bin/empc.c | 8 ++++---- src/bin/empdd.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/bin/empc.c b/src/bin/empc.c index e465c1c..7fb0d61 100644 --- a/src/bin/empc.c +++ b/src/bin/empc.c @@ -805,7 +805,7 @@ songid_update(int songid) { Eina_Bool artist, album, first = (empd_songid == -1); Elm_Object_Item *it, *itp = NULL; - Empd_Empdd_Song *so, *sop; + Empd_Empdd_Song *so, *sop = NULL; int ret, uid = background_num; if (empd_songid == songid) return 0; @@ -1242,7 +1242,7 @@ filesystem_paste_download_start(void *data EINA_UNUSED, Evas_Object *obj, void * static Evas_Object * filesystem_item_content_get(Empc_Entity *ent, Evas_Object *obj, const char *part EINA_UNUSED) { - Empc_Fetch_Request *req; + Empc_Fetch_Request *req = NULL; Evas_Object *cur = NULL, *img = NULL; Eina_Stringshare *uri = NULL; Elm_Selection_Data *ev; @@ -1338,7 +1338,7 @@ filesystem_item_content_get(Empc_Entity *ent, Evas_Object *obj, const char *part } if (img) evas_object_unref(img); - else if (!uri) + else if (req && (!uri)) evas_object_event_callback_add(cur, EVAS_CALLBACK_DEL, filesystem_item_content_del, req); eina_stringshare_del(uri); break; @@ -1981,7 +1981,7 @@ queue_list_delete_selected(void) Elm_Object_Item *it, *next, *hdr = NULL; Eina_Bool del_playing = EINA_FALSE; Empd_Empdd_Song *so; - unsigned int sub; + unsigned int sub = 0; items = elm_genlist_selected_items_get(queue_list); if (!items) return; diff --git a/src/bin/empdd.c b/src/bin/empdd.c index be14b86..805ca31 100644 --- a/src/bin/empdd.c +++ b/src/bin/empdd.c @@ -1347,7 +1347,7 @@ static const Eldbus_Service_Interface_Desc base_desc = int main(int argc, char *argv[]) { - struct mpd_settings *settings; + struct mpd_settings *settings = NULL; const char *h, *pass, *p = NULL; pass = getenv("MPD_PASSWORD"); --
