2016-04-19 7:01 GMT+02:00 Jee-Yong Um <[email protected]>: > sanghyeonlee pushed a commit to branch master. > > > http://git.enlightenment.org/core/efl.git/commit/?id=87b12327c3356ac8233cb5a08260625221239153 > > commit 87b12327c3356ac8233cb5a08260625221239153 > Author: Jee-Yong Um <[email protected]> > Date: Tue Apr 19 13:59:59 2016 +0900 > > genlist: scroll to item when calc is done > > Summary: > If elm_genlist_item_bring_in() is called immediately after appending > item, genlist will not scroll to the last one but stop in the middle. > This patch blocks genlist from scrolling to not calculated item. > > Test Plan: > 1. Uncompress attached file > 2. make > 3. ./test >
This is somehow wrong, in your test just change ITEM_NUM to 30 to see that it is not working anymore, please give a look into this, it also seems to create some other unwanted side effect in some of my apps. > > Reviewers: cedric, SanghyeonLee > > Reviewed By: SanghyeonLee > > Subscribers: jpeg > > Differential Revision: https://phab.enlightenment.org/D3861 > --- > src/lib/elementary/elm_genlist.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/lib/elementary/elm_genlist.c > b/src/lib/elementary/elm_genlist.c > index f204537..1e8ec97 100644 > --- a/src/lib/elementary/elm_genlist.c > +++ b/src/lib/elementary/elm_genlist.c > @@ -582,6 +582,9 @@ _item_scroll(Elm_Genlist_Data *sd) > dw = it->item->block->w; > dh = oh; > > + // hold on scrolling to item until block size calculation is finished. > + if (dw < 1) return; > + > switch (sd->scroll_to_type) > { > case ELM_GENLIST_ITEM_SCROLLTO_TOP: > > -- > > > ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
