barbieri pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=db1e2b994ef75163dcd8286ae8b9649d5fb7217e
commit db1e2b994ef75163dcd8286ae8b9649d5fb7217e Author: Gustavo Sverzut Barbieri <[email protected]> Date: Mon Dec 19 16:52:29 2016 -0200 efl_net_socket_ssl: remove TODO leftover. There are no jobs to stop there, it was a left over since this code was somehow derived from Efl.Loop_Fd where "read" and "write" would constantly be called until the kernel flag was cleared, there the callback must be removed to stop jobs, not here. --- src/lib/ecore_con/efl_net_socket_ssl.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/lib/ecore_con/efl_net_socket_ssl.c b/src/lib/ecore_con/efl_net_socket_ssl.c index c776ad4..63252b9 100644 --- a/src/lib/ecore_con/efl_net_socket_ssl.c +++ b/src/lib/ecore_con/efl_net_socket_ssl.c @@ -162,10 +162,7 @@ efl_net_socket_ssl_sock_can_read_changed(void *data, const Efl_Event *event EINA efl_ref(o); /* we're emitting callbacks then continuing the workflow */ if (!efl_io_reader_can_read_get(pd->sock)) - { - // TODO: stop jobs? - goto end; - } + goto end; if (pd->did_handshake) efl_io_reader_can_read_set(o, EINA_TRUE); @@ -185,10 +182,7 @@ efl_net_socket_ssl_sock_can_write_changed(void *data, const Efl_Event *event EIN efl_ref(o); /* we're emitting callbacks then continuing the workflow */ if (!efl_io_writer_can_write_get(pd->sock)) - { - // TODO: stop jobs? - goto end; - } + goto end; if (pd->did_handshake) efl_io_writer_can_write_set(o, EINA_TRUE); --
