Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=545039 Thomas Spura <toms...@fedoraproject.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |toms...@fedoraproject.org --- Comment #1 from Thomas Spura <toms...@fedoraproject.org> 2009-12-18 09:37:22 EDT --- Just a few comments for now: - https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define - Why do you use add_files and not the normal %files section? - Why do you install in a own created directory and don't use $RPM_BUILD_ROOT? - nspr_version is not existent. Is it even needed? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
