Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libconcord - Library to talk to Logitech® Harmony® universal remote controls https://bugzilla.redhat.com/show_bug.cgi?id=438105 ------- Additional Comments From [EMAIL PROTECTED] 2008-03-21 01:56 EST ------- A few more, then I'll stop for the night! 1) Missing "Requires: libusb", or does that get picked up automatically by rpm based on running ldd on libconcord.so? 2) I don't think you need "Requires: /sbin/ldconfig" since it's part of the base package set. If you are going to include this, it seems common to only require it for script execution time, e.g.: libgeda/devel/libgeda.spec:16:Requires(post): /sbin/ldconfig libgeda/devel/libgeda.spec:17:Requires(postun): /sbin/ldconfig 3) There are more (double and more) blank lines in the spec than there probably should be, according to examples I've seen of existing spec files. Not a functional problem, but best to keep formatting consistent with existing specs and fedora Wiki examples. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
