Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: nautilus-sound-converter - nautilus extension to 
convert audio files


https://bugzilla.redhat.com/show_bug.cgi?id=448250





------- Additional Comments From [EMAIL PROTECTED]  2008-06-01 10:17 EST -------
+ There remains an issue with mixed use of spaces and tabs:
[EMAIL PROTECTED] SRPMS]$ rpmlint nautilus-sound-converter-0.5.0-2.fc9.src.rpm 
nautilus-sound-converter.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1,
tab: line 24)
[EMAIL PROTECTED] SRPMS]$ 

+ Also are these versioned BuildRequires really needed? Even F-7 seems to have
versions newer than these.
BuildRequires:  nautilus-devel >= 2.12.0
BuildRequires:  gstreamer-devel >= 0.10.3

According to https://fedoraproject.org/wiki/Packaging/Guidelines#Requires :
"... if the lowest possible requirement is so old that nobody has a version
older than that installed on any target distribution release, there's no need to
include the version in the dependency at all. In that case we know the available
software is new enough. ... As a rule of thumb, if the version is not required,
don't add it just for fun."

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review

Reply via email to