On Sun, 31 Oct 2021 21:25:44 +0100 Bernhard Reutner-Fischer <rep.dot....@gmail.com> wrote:
> On Sun, 31 Oct 2021 20:46:07 +0100 > Harald Anlauf <anl...@gmx.de> wrote: > > > Am 30.10.21 um 23:51 schrieb Bernhard Reutner-Fischer via Fortran: > > >>> The only caller is translate_all_program_units. > > >>> Since we free only module gsyms, even -fdump-fortran-global is > > >>> unaffected by this, fwiw. > > > > > > AFAICS we do not have a test for -fdump-fortran-global > > > Do we want to add one, would the attached be OK? > > > > This doesn't seem to test anything new or changed, or a bug fixed. > > I get the same result for all version from 9 to 12-mainline. > > So as is it seems pointless. > > Yes indeed, it just adds coverage to that functionality which we did not > exercise before. > TBH i only found that option when looking around > translate_all_program_units. I've never actually used that option > myself and cannot imagine how it is useful at all :) > > Dropped the testcase. > Thanks for your comment! The rest of 5c6aa9a8919cbf0dcf3c375f51012720bfb5f3a1 is fine, but should we really keep the option, if we don't even test basics and if it was more a specific debug dump, from the looks? Thomas? thanks,