Hopefully we'll get there in the end!  I've updated what I can in the patch file directly, so hopefully all is well now.

Some of the variable names, like "ProcName", were already named as such.

Gareth aka. Kit

On 09/07/2019 10:12, Sven Barth via fpc-devel wrote:
J. Gareth Moreton <gar...@moreton-family.com <mailto:gar...@moreton-family.com>> schrieb am Di., 9. Juli 2019, 08:20:

    Apologies - I see now... I used them with "with" without even
    thinking
    about it!  I've made the changes as requested. Admittedly it's quite
    hard for me to remove spaces from either side of operators because
    that's something I learnt from my early days in Turbo Pascal and
    to not
    have spaces (and all types and variables being lowercase) feels very
    C-like.  But hey, rules are rules... or guidelines!


I know the feeling. But when in Rome...

    Is the new AS-IS-enum-08 patch any better?


Better (though are still some " = " around :P ), but it seems you missed tasnode.pass_1? Also the typenames (TOrdDef, TEnumDef) should be lowercase as well as the local variables.

Regards,
Sven


_______________________________________________
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus
_______________________________________________
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
https://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel

Reply via email to