FVWM Bug Tracking notification

new message incoming/738

Message summary for PR#738
        From: [EMAIL PROTECTED]
        Subject: gcc-3.0 compilation with optimizations
        Date: Wed, 11 Jul 2001 06:02:17 -0500
        0 replies       0 followups

====> ORIGINAL MESSAGE FOLLOWS <====

>From [EMAIL PROTECTED] Wed Jul 11 06:02:22 2001
Received: from karazm.math.uh.edu ([129.7.128.1])
        by malifon.math.uh.edu with esmtp (Exim 3.20 #1)
        id 15KHl8-0007va-00
        for [EMAIL PROTECTED]; Wed, 11 Jul 2001 06:02:22 -0500
Received: from malifon.math.uh.edu (IDENT:[EMAIL PROTECTED] [129.7.128.13])
        by karazm.math.uh.edu (8.9.3/8.9.3) with ESMTP id GAA00160
        for <[EMAIL PROTECTED]>; Wed, 11 Jul 2001 06:02:17 -0500 (CDT)
From: [EMAIL PROTECTED]
Received: from localhost ([127.0.0.1] ident=65534)
        by malifon.math.uh.edu with esmtp (Exim 3.20 #1)
        id 15KHl3-0007vW-00
        for [EMAIL PROTECTED]; Wed, 11 Jul 2001 06:02:17 -0500
To: [EMAIL PROTECTED]
Subject: gcc-3.0 compilation with optimizations
Message-Id: <[EMAIL PROTECTED]>
Date: Wed, 11 Jul 2001 06:02:17 -0500

Full_Name: Guillaume Chazarain
Version: 2.4.0
CVS_Date: 
OS: linux-2.4.6-ac2
X_Server: XFree86-4.1.0
Submission from: (NULL) (134.59.9.99)


Hello, here is a patch for a bug that I suspect
not to be in fvwm.
Let me explain :
When compiling fvwm2 with gcc 3.0 under linux and
CFLAGS="-pipe -O2 -march=i686 -fomit-frame-pointer"
fvwm crashes at startup, the problem is that it
doesn't with older gcc or less aggressive optimizations.
So here is a dirty patch to fix this :
--------------------------------------------------------
diff -Naur fvwm-2.4.0/fvwm/builtins.c fvwm-2.4.0.gcc3/fvwm/builtins.c
--- fvwm-2.4.0/fvwm/builtins.c  Tue Jun 26 14:44:02 2001
+++ fvwm-2.4.0.gcc3/fvwm/builtins.c     Tue Jul 10 19:50:51 2001
@@ -1015,7 +1015,7 @@
   decor->flags.has_changed = 1;
   decor->titlebar.flags.has_changed = 1;
 
-  for (prev = action ; (parm = PeekToken(action, &action)); prev =
action)
+  for (prev = action ; (action && (parm = PeekToken(action, &action)));
prev = 
action)
   {
     if (!do_add && StrEquals(parm,"centered"))
     {
-------------------------------------------------------
The problem is that a NULL pointer is dereferenced.
Furthermore, I think this patch is not the solution, it's
just quick hack that lets me use gcc 3.0 and fvwm.


--
Visit the official FVWM web page at <URL:http://www.fvwm.org/>.
To unsubscribe from the list, send "unsubscribe fvwm-workers" in the
body of a message to [EMAIL PROTECTED]
To report problems, send mail to [EMAIL PROTECTED]

Reply via email to