On Mon, Jan 07, 2002 at 02:00:24PM -0500, Andrew Pimlott wrote: > I was using the fvwm distributed in the Debian Testing distribution (based > on 2.2.5), and I noticed that if the configuration had two > *FwwmPagerGeometry settings (eg, one in the system config file, one in the > user config file), they would interfere with each other. For example, the > default /etc/X11/fvwm/system.fvwm2rc has > > *FvwmPagerGeometry -0-0 > > and my own ~/.fvwm/post.hook (part of Debian's config setup) has > > *FvwmPagerGeometry -0+0 > > but the result is that the pager appears in the lower-right corner, instead > of the upper-right. > > The reason is that the config reader in FvwmPager.c updates the parts of the > geometry independently, based on what was specified in the geometry string. > So my geometry string doesn't override the fact that YNegative was already > set by the system geometry string. > > I downloaded 2.4.4 and found that it had been fixed in the obvious way, by > resetting all components of the geometry every time a new geometry setting > is encountered. But I poked around a little more and discovered that > several other files have the same bug. Below is a patch that corrects every > instance I found (by grepping for ParseGeometry in **/*.c) in a recent > snapshot. I tried to address only the cases where the geometry might > plausibly be specified more than once. > > I compiled this but did not run it. This is the first time I've looked at > the fvwm sources, so please take only what makes sense. > > Making these changes was a pain, because I had to hunt down the default > values of all the geometry parts and duplicate them (which sucks for future > maintenance). I note that some modules (such as FvwmTaskBar) do something > much simpler and saner: they store only the geometry string when reading the > config, and parse it (ie, the last one read) after the whole config is read. > This is a better solution if someone feels like doing it. > > I'm not subscribed, so please Cc: me on any follow-ups.
Thanks for your help. I'll apply that patch shortly. Bye Dominik ^_^ ^_^ -- Dominik Vogt, email: [EMAIL PROTECTED] LifeBits Aktiengesellschaft, Albrechtstr. 9, D-72072 Tuebingen fon: ++49 (0) 7071/7965-0, fax: ++49 (0) 7071/7965-20 -- Visit the official FVWM web page at <URL:http://www.fvwm.org/>. To unsubscribe from the list, send "unsubscribe fvwm-workers" in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
