On Tue, May 07, 2002 at 04:08:44PM +0200, Dominik Vogt wrote: > On Tue, May 07, 2002 at 02:28:19PM +0100, tim phipps wrote: > > Configuration Information [Automatically generated, do not change]: > > uname: SunOS silver 5.5.1 Generic_103640-40 sun4u sparc SUNW,Ultra-5_10 > > compiler flags: gcc -g -O2 -Wall -Wno-implicit-int > > > > FVWM Version: 2.5.2 > > FVWM_MODULEDIR: /u/phippst/sunos/libexec/fvwm/2.5.2 > > FVWM_DATADIR: /u/phippst/sunos/share/fvwm > > FVWM_USERDIR: /u/phippst/.fvwm > > > > Description: > > I get a core dump when executing this line: > > Colorset 0 DGradient 100 #0f0f9f #0000ff, bg Average, fg Contrast, sh > > #0f0f9f, hi #0000ff > > Fixed. Olivier, please take a look at colorset.c. There were a > number of bugs with the cs->picture structure (accessing members > when it was NULL, comparing the pointer with 'None' instead of > NULL, checks in 'if' bodies where cs->picture wasn't used at all). > I'm not sure I've done everything right. >
Yes, the core dump was my fault. I was/am a bit confused with average bg and tinting. I recheck again and I've fixed an other possible core dump (related to bitmap). I hope that everything is ok now. About average and tinting. Tint/TintMask allows to tint a pixmap, my pbs is: do we have to compute the average bg after tinting or not. With Tint, as the bg is also tinted, it seems that we have to compute the average bg before tinting (but sh/hi maybe "wrong") as with TintMask nothing is clear for me. So I take the simple way: average bg is computed from the original pixmap, that's all. Any other suggestions? About bitmap I think it will be good to be able to define the bg and the fg of the bitmap. The bitmap currently used the fg and bg color and this gives unreadable text (if you do not use a tint). Any objection for a bitmap_bg and a bitmap_fg options to the colorset command? Others ideas: - Add an fg_alpha option : with xft rendering we can apply an alpha channel to the text. Maybe good for "greyed" menu colorset and buttons in IconMan which represent an iconified window. - Add an Pixmap_alpha option: to put the pixmap in a translucent way on the bg. - Add an IconTint option: when we have to display a mini icon (or an icon) on a colorset background the (mini) icon is tinted. May be good again with greyed menu colorset and buttons in IconMan which represents an iconified window (IconTint white 30). Olivier -- Visit the official FVWM web page at <URL:http://www.fvwm.org/>. To unsubscribe from the list, send "unsubscribe fvwm-workers" in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
