On Mon, May 19, 2003 at 10:39:30AM +0000, Mikhael Goikhman wrote: > On 19 May 2003 08:52:23 +0200, Dominik Vogt wrote: > > > > On Mon, May 19, 2003 at 03:01:38AM +0200, Olivier Chapuis wrote: > > > Hello, > > > > > > Attached to this msg 2 new cmds StyleById and DestroyStyleById. > > > StyleById applies styles to specific windows: > > > > > > Pick Style $[w.id] NoTitle, !Borders > > > > > > DestroyStyleById can destroy such a style. > > > > > > The implementation solve the pbs with the patch send by Craig Milo Rogers > > > a few weeks ago: > > > - When a window is "destroyed" the associated StyleById is destroyed > > > too (if not a new window can have the same id and the old style by > > > id is applied). > > > - No more ambiguity with the Style cmd as we have a new cmd. > > > > > > I see no strong reason against this patch, but (as we are under > > > feature freeze) a vote against it. Any one? > > > > Adding the patch to 2.5.x is out of the question (feature freeze). > > Apart from that, this topic requires much more thought. We don't > > want to make an ad-hoc syntax now, find out later that it does not > > work with all the other Style related enhancements and the > > redesign exevrything from scratch. > > I would like to see WindowStyle and DestroyWindowStyle in 2.6.x as > implemented in the patch, it makes many things clean and possible. > > Either it is called new or old, it's a good feature. Can you argue that:
2.5.x is in feature freeze. If you feel the need to add new and potentially disrupting features now, please split off a new project and do it in a separate CVS repository. Full stop. > * The patch in the question is not problematic (you may verify it). Of course it is problematic. Style handling itself is very delicate and one of the richest sources of bugs. Just read the archives to get a feeling for what I mean. > * We already discussed WindowStyle and decided (including Dominik) that > this is the right thing to do. It even (together with StyleFunction) > may eventually replace Style as we know it now. Having WindowStyle > that works on window context is good regardless of whether we have > Style or StyleFunction. Please speak only for yourself. I never agreed to a particular solution and I won't participate in a design discussion at this point in time. Bye Dominik ^_^ ^_^ -- Visit the official FVWM web page at <URL:http://www.fvwm.org/>. To unsubscribe from the list, send "unsubscribe fvwm-workers" in the body of a message to [EMAIL PROTECTED] To report problems, send mail to [EMAIL PROTECTED]
