On Sat, Jun 03, 2006 at 07:28:11PM +0100, Thomas Adam wrote: > On Sat, Jun 03, 2006 at 11:57:58AM -0400, Dan Espen wrote: > > > > It's been a while since I've updated to CVS Maybe a month or 2 . > > > > After the last update, the text in my window titles is black. These > > commands have no effect: > > > > Style * ForeColor HilightFore > > Last I heard those commands were being deprecated in favour of using > colorsets.
They are not desprecated at the moment.
I know about this problem and I'm quite sure which particular
commit caused it:
2006-02-09 Dominik Vogt <...>
...
* libs/Flocale.c (FlocaleFontStructDrawString):
(FlocaleDrawString):
set the foreground colour before drawing a string
(diff attached).
Unfortunately I never got any feedback on this from the person who
reported it first. The problem was that in some cases the GC used
to draw the title was not set before drawing, but it seems the old
code relied on this not being done.
I'd be grateful if someone could look into this problem or at
least give me a minimal config to reproduce it.
Ciao
Dominik ^_^ ^_^
--
Dominik Vogt, [EMAIL PROTECTED]
Index: Flocale.c
===================================================================
RCS file: /home/cvs/fvwm/fvwm/libs/Flocale.c,v
retrieving revision 1.75
retrieving revision 1.76
diff -u -B -b -u -r1.75 -r1.76
--- Flocale.c 26 Nov 2005 21:55:12 -0000 1.75
+++ Flocale.c 9 Feb 2006 11:49:33 -0000 1.76
@@ -617,6 +617,9 @@
is_string16, dpy, d, gc, xt, yt,
fws->e_str, fws->str2b, len);
}
+ }
+ if (has_fg_pixels)
+ {
XSetForeground(dpy, gc, fg);
}
xt = gstp_args.orig_x;
@@ -909,7 +912,6 @@
dpy, fws->win, my_gc, xpsh, ypsh, rotated_w,
rotated_h);
}
- XSetForeground(dpy, my_gc, fg);
}
xpsh = gstp_args.orig_x;
ypsh = gstp_args.orig_y;
@@ -1932,8 +1935,8 @@
dpy, fws->win, flf->fontset, fws->gc,
xt, yt, fws->e_str, len);
}
- XSetForeground(dpy, fws->gc, fg);
}
+ XSetForeground(dpy, fws->gc, fg);
xt = gstp_args.orig_x;
yt = gstp_args.orig_y;
XmbDrawString(
@@ -2001,8 +2004,8 @@
buf2,
strlen(buf2));
}
- XSetForeground(dpy, fws->gc, fg);
}
+ XSetForeground(dpy, fws->gc, fg);
xt = gstp_args.orig_x;
yt = gstp_args.orig_y;
XmbDrawString(
signature.asc
Description: Digital signature
