This commits fixes three instances of harmless but redundant code,
detected by cppcheck.
gcc/algol68/ChangeLog
PR algol68/122954
* a68-low-clauses.cc (serial_clause_dsa): Avoid redundant
initialization.
* a68-parser-modes.cc (compute_derived_modes): Likewise.
* a68-low.cc (a68_lower_tree): Remove redundant break.
---
gcc/algol68/a68-low-clauses.cc | 4 +---
gcc/algol68/a68-low.cc | 1 -
gcc/algol68/a68-parser-modes.cc | 3 +--
3 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/gcc/algol68/a68-low-clauses.cc b/gcc/algol68/a68-low-clauses.cc
index 77e07b1121b..8cc81500b23 100644
--- a/gcc/algol68/a68-low-clauses.cc
+++ b/gcc/algol68/a68-low-clauses.cc
@@ -58,9 +58,7 @@
static bool
serial_clause_dsa (NODE_T *p)
{
- NODE_T *s = NEXT (SUB (p));
-
- for (s = p; SUB (s) && IS (s, SERIAL_CLAUSE); s = SUB (s))
+ for (NODE_T *s = p; SUB (s) && IS (s, SERIAL_CLAUSE); s = SUB (s))
{
if (DYNAMIC_STACK_ALLOCS (s))
return true;
diff --git a/gcc/algol68/a68-low.cc b/gcc/algol68/a68-low.cc
index 109620248fb..ac603ef13e7 100644
--- a/gcc/algol68/a68-low.cc
+++ b/gcc/algol68/a68-low.cc
@@ -1479,7 +1479,6 @@ a68_lower_tree (NODE_T *p, LOW_CTX_T ctx)
case PACKET:
res = lower_packet (p, ctx);
break;
- break;
case PRELUDE_PACKET:
res = lower_prelude_packet (p, ctx);
break;
diff --git a/gcc/algol68/a68-parser-modes.cc b/gcc/algol68/a68-parser-modes.cc
index 4a0128667ca..83f40a0615a 100644
--- a/gcc/algol68/a68-parser-modes.cc
+++ b/gcc/algol68/a68-parser-modes.cc
@@ -1202,10 +1202,9 @@ compute_derived_modes (MODULE_T *mod)
for (; s != NO_PACK; FORWARD (s))
{
- PACK_T *t = NEXT (s);
bool x = true;
- for (t = NEXT (s); t != NO_PACK && x; FORWARD (t))
+ for (PACK_T *t = NEXT (s); t != NO_PACK && x; FORWARD (t))
{
if (TEXT (s) == TEXT (t))
{
--
2.30.2