Giacomo Travaglini has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/24683 )
Change subject: system-arm: AArch64 boot, init CNTFRQ_EL0
......................................................................
system-arm: AArch64 boot, init CNTFRQ_EL0
CNTFRQ_EL0 should be initialised to a uniform value in all cores present
in the system. Previously, this was only done if EL3 was present,
however architecture states CNTFRQ_EL0 may be written from the highest
EL implemented.
This patch moves this initilization outside of the EL3-only one.
Change-Id: Ibaa197de53d531ba898e5137ba4f46a8c9554699
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/24683
Reviewed-by: Gabe Black <gabebl...@google.com>
Maintainer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M system/arm/bootloader/arm64/boot.S
1 file changed, 2 insertions(+), 7 deletions(-)
Approvals:
Gabe Black: Looks good to me, approved
Giacomo Travaglini: Looks good to me, approved
kokoro: Regressions pass
diff --git a/system/arm/bootloader/arm64/boot.S
b/system/arm/bootloader/arm64/boot.S
index 38090c8..fa7acdb 100644
--- a/system/arm/bootloader/arm64/boot.S
+++ b/system/arm/bootloader/arm64/boot.S
@@ -40,6 +40,8 @@
.globl _start
_start:
+ ldr x0, =CNTFRQ
+ msr cntfrq_el0, x0
/*
* EL3 initialisation
*/
@@ -55,9 +57,6 @@
msr cptr_el3, xzr // Disable copro. traps to EL3
- ldr x0, =CNTFRQ
- msr cntfrq_el0, x0
-
/*
* Check for the primary CPU to avoid a race on the distributor
* registers.
@@ -180,10 +179,6 @@
str wzr, [x4, #0xa0] // V2M_SYS_CFGDATA
str w5, [x4, #0xa4] // V2M_SYS_CFGCTRL
- // set up the arch timer frequency
- //ldr x0, =CNTFRQ
- //msr cntfrq_el0, x0
-
/*
* Primary CPU
*/
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/24683
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Ibaa197de53d531ba898e5137ba4f46a8c9554699
Gerrit-Change-Number: 24683
Gerrit-PatchSet: 2
Gerrit-Owner: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Chun-Chen TK Hsu <chunchen...@google.com>
Gerrit-Reviewer: Gabe Black <gabebl...@google.com>
Gerrit-Reviewer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
