On 02/03/2015 08:55 PM, Anthony G. Basile wrote: > On 02/02/15 19:06, viv...@gmail.com wrote: >> Il 02/02/2015 23:30, Pacho Ramos ha scritto: >>> El sáb, 31-01-2015 a las 16:48 -0500, Anthony G. Basile escribió: >>>> Hi everyone, >>>> >>>> We need to revert the following change to toolchain.eclass: >>>> >>>> http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/toolchain.eclass?r1=1.647&r2=1.648 >>>>
>>> Please remember to add a comment to the eclass with the reference to not >>> forget in the future why fixincludes stuff is needed ;) >>> >> fixincludes only on prefix and bsd is doable/acceptable? > > @pacho. absolutely. part of the process is me learning the layers of > history there. > its not like the code is hard to read, its just "why was this done?". > > @vivo75. the fixedincludes are removed after compiling, so they don't make it > to $ROOT > during qmerge either for linux or bsd/prefix. > Its just that are needed during compiling for fbsd/prefix. To complete this info: At least in prefix they have to be installed as well, as subsequent packages may still use host's (libc at least) headers, and gcc requires them to be "fixed". > So a straight revert is fine. Fine for now, it's forked in prefix-overlay still. > We need to explain this in a comment in case some "clever" future dev doesn't > comes to the > same erroneous conclusion, that its okay to just disable their build. Thanks! /haubi/
