Thanks to both of you for the hard work, Kevin if you are working on that branch please remember to coordinate with the email list.
I will catch up mid week. On Sun, Mar 6, 2016 at 9:36 AM Justin Deoliveira <[email protected]> wrote: > Thanks Andrea. Comments inline. > > On Sun, Mar 6, 2016 at 3:00 AM Andrea Aime <[email protected]> > wrote: > >> Hi Justin, >> had a very quick look, GeoServer wise the only thing I noticed was the >> lack of header upgrades (which >> can be done later), all the other changes look reasonable (but mind, I >> haven't used Spring 4 anywhere else). >> >> >> On Sat, Mar 5, 2016 at 6:23 PM, Justin Deoliveira <[email protected]> >> wrote: >> >>> Hey folks, thought I would send a quick update on progress. To recap the >>> branch currently being worked on is here: >>> >>> https://github.com/geoserver/geoserver/tree/spring4-upgrade >>> >>> The branch currently contains: >>> >>> - Core upgrades to spring 4.2.5 and spring security 4.0.4 >>> - Upgrade to servlet api 3.0.1 >>> - Andreas work to migrate from mockrunner to spring-test >>> >>> I also pushed a branch for geowebcache: >>> >>> https://github.com/GeoWebCache/geowebcache/tree/spring-servlet-upgrade >>> >> >> Tried to build this one, I get a failure in gwc-wmts: >> >> Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 11.632 >> sec <<< FAILURE! >> testGetTileWithStyle(org.geowebcache.service.wmts.WMTSServiceTest) Time >> elapsed: 0.416 sec <<< FAILURE! >> java.lang.AssertionError: >> Expected: map containing ["STYLES"->"Bar"] >> but: map was [] >> at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) >> at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:8) >> at >> org.geowebcache.service.wmts.WMTSServiceTest.testGetTileWithStyle(WMTSServiceTest.java:524) >> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >> at >> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) >> at >> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >> at java.lang.reflect.Method.invoke(Method.java:498) >> at junit.framework.TestCase.runTest(TestCase.java:176) >> at junit.framework.TestCase.runBare(TestCase.java:141) >> at junit.framework.TestResult$1.protect(TestResult.java:122) >> at junit.framework.TestResult.runProtected(TestResult.java:142) >> at junit.framework.TestResult.run(TestResult.java:125) >> at junit.framework.TestCase.run(TestCase.java:129) >> at junit.framework.TestSuite.runTest(TestSuite.java:255) >> at junit.framework.TestSuite.run(TestSuite.java:250) >> at >> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84) >> at >> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252) >> at >> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141) >> at >> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112) >> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >> at >> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) >> at >> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >> at java.lang.reflect.Method.invoke(Method.java:498) >> at >> org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189) >> at >> org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165) >> at >> org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85) >> at >> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115) >> at >> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75) >> >> It was a simple fix for a mock expectation, so I've fixed it. One liner >> change pushed to the branch. >> > > Nice, thanks! > >> >> >>> >>> Although it looks like Kevin already did the work here?: >>> >>> https://github.com/GeoWebCache/geowebcache/tree/spring4-upgrade >>> >> >> Looks like this one misses the servlet api upgrade though. >> >> >>> >>> >>> At any rate, one of those branches will be required to build the >>> geoserver branch. >>> >>> At the moment all the core modules compile and pass tests. With the >>> exception of one wms test that from what I can tell was some wierd osx >>> failure. It would be nice if someone else could verify that though. >>> >> >> No failures in wms here (also made a fresh build of geotools to be on the >> safe side), do you have details? >> I've made a full build and I have failures in the following extensions: >> CAS (expected), WPS, XSLT, monitoring hibernate... not all >> that many in the end. >> Assuming you're not working on it right now, I'm going to have a quick >> look. >> >> > I’ve attached the failure trace I get > from testCoverageViewMap(org.geoserver.wms.wms_1_1_1.GetMapIntegrationTest). > I am pretty sure I have seen this failure before in my environment. > > > >>> I’ve also run the server and everythign starts up ok, but I haven’t >>> poked it much harder than a quick smoke test. >>> >>> There is one interesting thing that I found with spring security. The >>> login and logout endpoints have changed. So “/j_spring_security_check" is >>> now “/login” and “/j_spring_security_logout” is now “/logout”. I’m still >>> unsure what the backwards compatability repercussions will be with this. It >>> looks like those paths are configurable in some places (like if using >>> annotation based config) but the way we are using some of the filters it >>> didn’t look like they were. I was going to circle back to this. >>> >> >> Hum... thinking, don't we have some javascript apps around using these >> endpoints to test authentication >> when using a custom login form? >> > Yeah, I know of one app (geoexplorer) that uses one of the endpoints to > create a session. One thought I had (if we can’t configure the endpoint > paths) was to create a redirect from old to the new. > >> >> Cheers >> Andrea >> >> -- >> == >> GeoServer Professional Services from the experts! Visit >> http://goo.gl/it488V for more information. >> == >> >> Ing. Andrea Aime >> @geowolf >> Technical Lead >> >> GeoSolutions S.A.S. >> Via di Montramito 3/A >> 55054 Massarosa (LU) >> phone: +39 0584 962313 >> fax: +39 0584 1660272 >> mob: +39 339 8844549 >> >> http://www.geo-solutions.it >> http://twitter.com/geosolutions_it >> >> *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003* >> >> Le informazioni contenute in questo messaggio di posta elettronica e/o >> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il >> loro utilizzo è consentito esclusivamente al destinatario del messaggio, >> per le finalità indicate nel messaggio stesso. Qualora riceviate questo >> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di >> darcene notizia via e-mail e di procedere alla distruzione del messaggio >> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, >> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od >> utilizzarlo per finalità diverse, costituisce comportamento contrario ai >> principi dettati dal D.Lgs. 196/2003. >> >> >> >> The information in this message and/or attachments, is intended solely >> for the attention and use of the named addressee(s) and may be confidential >> or proprietary in nature or covered by the provisions of privacy act >> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection >> Code).Any use not in accord with its purpose, any disclosure, reproduction, >> copying, distribution, or either dissemination, either whole or partial, is >> strictly forbidden except previous formal approval of the named >> addressee(s). If you are not the intended recipient, please contact >> immediately the sender by telephone, fax or e-mail and delete the >> information in this message that has been received in error. The sender >> does not give any warranty or accept liability as the content, accuracy or >> completeness of sent messages and accepts no responsibility for changes >> made after they were sent or for other risks which arise as a result of >> e-mail transmission, viruses, etc. >> >> ------------------------------------------------------- >> > > ------------------------------------------------------------------------------ > _______________________________________________ > Geoserver-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/geoserver-devel > -- -- Jody Garnett
------------------------------------------------------------------------------
_______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
