Updated pull request based on feedback:
https://github.com/geoserver/geoserver/pull/2615
Cheers
Andrea
On Mon, Oct 30, 2017 at 7:25 PM, Jody Garnett <jody.garn...@gmail.com>
wrote:
> Okay, sounds good. I was just thrown off by extending TransactionListener.
>
> --
> Jody Garnett
>
> On 30 October 2017 at 10:58, Andrea Aime <andrea.a...@geo-solutions.it>
> wrote:
>
>> On Mon, Oct 30, 2017 at 6:16 PM, Jody Garnett <jody.garn...@gmail.com>
>> wrote:
>>
>>> I like your extension and a half logic :)
>>>
>>
>>> Notes for discussion:
>>> - I am not used to seeing "plugin" in a classname, would expect
>>> TransactionListener2
>>> (since it extends TransactionListener).
>>>
>>
>> The notion of "before commit" to allow modification the transaction seems
>> nonsense, the transaction
>> needs to be changed before it even starts getting translated down into
>> GeoTools terms and hitting the stores,
>> not "just before commit" (which is the final act in a transaction).
>> Also TransactionPlugin is working at a level that is one step above
>> semantically, and mismatched too:
>>
>> - The request is expressed in WFS terms, and a plugin might modify it
>> considering all of its elements at the same time (or remove elements and
>> replace them with others)
>> - WFS has no notion of commit or rollback, that's internal machinery
>> - GeoTools has such notion, but TransactionRequest is not expressed
>> in those terms (while TransactionListener/TransactionEvent is firmly
>> rooted in a single GeoTools store level interaction, with feature
>> collections always available in all events)
>>
>> Rollback management is also down in GeoTools, but no active modification
>> would be allowed in there.
>> Long story short, if you think you need richer events, feel free to make
>> your own proposals, but what
>> you're proposing is to fit a square peg in a round hole :-)
>>
>> What about:
>>
>> - I stop making TransactionPlugin2 extend TransactionListener (which
>> indeed sounds like a mistake given their differences, probably back at the
>> time it was done like that because the object that needed
>> TransactionPlugin
>> required implementing both, making them look more related than they
>> actually are)
>> - Rename it to TransactionCallback to avoid confusion (I'm so used to
>> the 10 years old interface name that I don't see it as a problem honestly,
>> but not attached to the name either)
>>
>> For the rest of proposed changes, I'm against for the reasons stated
>> above.
>>
>> Regards,
>>
>> Andrea Aime
>>
>>
>> ==
>> GeoServer Professional Services from the experts! Visit
>> http://goo.gl/it488V for more information.
>> ==
>>
>> Ing. Andrea Aime
>> @geowolf
>> Technical Lead
>>
>> GeoSolutions S.A.S.
>> Via di Montramito 3/A
>> <https://maps.google.com/?q=Via+di+Montramito+3/A+55054+%C2%A0Massarosa&entry=gmail&source=g>
>> 55054 Massarosa
>> <https://maps.google.com/?q=Via+di+Montramito+3/A+55054+%C2%A0Massarosa&entry=gmail&source=g>
>> (LU)
>> phone: +39 0584 962313 <+39%200584%20962313>
>> fax: +39 0584 1660272 <+39%200584%20166%200272>
>> mob: +39 339 8844549 <+39%20339%20884%204549>
>>
>> http://www.geo-solutions.it
>> http://twitter.com/geosolutions_it
>>
>> AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
>>
>> Le informazioni contenute in questo messaggio di posta elettronica e/o
>> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
>> loro utilizzo è consentito esclusivamente al destinatario del messaggio,
>> per le finalità indicate nel messaggio stesso. Qualora riceviate questo
>> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
>> darcene notizia via e-mail e di procedere alla distruzione del messaggio
>> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
>> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
>> utilizzarlo per finalità diverse, costituisce comportamento contrario ai
>> principi dettati dal D.Lgs. 196/2003.
>>
>> The information in this message and/or attachments, is intended solely
>> for the attention and use of the named addressee(s) and may be confidential
>> or proprietary in nature or covered by the provisions of privacy act
>> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
>> Code).Any use not in accord with its purpose, any disclosure, reproduction,
>> copying, distribution, or either dissemination, either whole or partial, is
>> strictly forbidden except previous formal approval of the named
>> addressee(s). If you are not the intended recipient, please contact
>> immediately the sender by telephone, fax or e-mail and delete the
>> information in this message that has been received in error. The sender
>> does not give any warranty or accept liability as the content, accuracy or
>> completeness of sent messages and accepts no responsibility for changes
>> made after they were sent or for other risks which arise as a result of
>> e-mail transmission, viruses, etc.
>>
>>
>
--
Regards,
Andrea Aime
==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
