Jody Garnett a écrit :
> org.geotools.data.crs
> ---------------------
> Initially created for GeoTools 2.0 to provide reader implementations for
> reprojection / forceprojection, initial AuthorityFactory interface provided
> for GeoTools 2.1 since deprecated and moved to referencing.
Just had a look to this package and have some comment:
- The package.html file seems irrelevant. Its look like a copy of a catalog
package description, which this package is supposed to be about CRS.
- I did a search on the whole geotools trunk for "CRSAuthoritySpi", and this
class doesn't seem to be referenced anymore. We could delete it since it
was deprecated in a pre-2.3 geotools version (if my memory serve me
right).
> org.geotools.data.jdbc.referencing
> ----------------------------------
> Seems to be added by jesse, probably a port of early access based EPSG
> authority?
> IP:
> - headers to (C) 2004-2006
> - TODO: ask Jesse for confirmation
I had a look to this JDBCAuthorityFactory, and its only purpose seems to be
used as a base class for
PostgisAuthorityFactory. I did a search in the whole Geotools trunk and found
no other usage. I
would like to suggest the following action (not IP related, but rather as a
code review):
- Deprecate the JDBCAuthorityFactory in Geotools 2.3 and delete it in
Geotools 2.4.
- Maybe move the PostgisAuthorityFactory from
org.geotools.data.postgis.referencing
to org.geotools.referencing.factory.postgis for consistency with other
CRS factories
(EPSG, AUTO, WMS...).
- PostgisAuthorityFactory extends BufferedAuthorityFactory instead of
JDBCAuthorityFactory.
The JDBCAuthorityFactory base class may be a little bit dangerous, since all
methods except one are
just implemented as "return null;". Throwing an exception instead would be
safer. In addition,
extending BufferedAuthorityFactory gives buffering (using weak references) for
free. Recent Andrea's
work on epsg-hsql show how an impressive peformance bost buffering can provides
on an authority
factory :).
If peoples agree, I can open a JIRA task for that and would volunter for doing
this job later this fall.
Martin.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
