Gabriel, I had a similar problem in ElementEncodeExecutor.visit(), where inappropriate conversion was being applied to ComplexAttribute, in that case causing failure, not just an ugly log message. The problem is that the converter support was written with simple features in mind. To fix the problem and preserve the existing simple feature behaviour, I added a !(object instanceof ComplexAttribute) check in ElementEncodeExecutor.visit(). Justin grumbled a bit, but you might get away with a similar fix as the ugly yet effective precedent has been set. :-)
Justin's concerns and my pleading are documented in GEOT-2474: http://jira.codehaus.org/browse/GEOT-2474 Kind regards, Ben. Gabriel Roldan wrote: > Hi, > > Working with an app-schema configuration on trunk works but the log gets > full of messages comming from GetPropertyExectutor, line 83: > > LOGGER.fine("Could not convert " + parent + " to " > + binding.getType().getName()); > > the messages look like the one bellow and are logged once per > ComplexAttribute. I'm not quite sure what the correct action to take is, > if relaxing the check and verify ComplexAttribute is a valid type for > the binding. At least I think we should avoid printing the full > attribute contents and instead just the attribute name? > > Example message: > 20 May 18:58:18 DEBUG [org.geotools.xml] - Could not convert > ComplexAttributeImpl:service<ServicePropertyType>=[FeatureImpl:Service<ServiceType > > id=service_4_4_4>=[ComplexAttributeImpl:name<CodeType>=[ServiceGroup_4_4], > AttributeImpl:name<string>=service 31, AttributeImpl:status<string>=0, > AttributeImpl:summary<string>=ex:summary, > AttributeImpl:headline<string>=ex:headline]] to org.opengis.feature.Feature -- Ben Caradoc-Davies <[email protected]> Software Engineer, CSIRO Exploration and Mining Australian Resources Research Centre 26 Dick Perry Ave, Kensington WA 6151, Australia ------------------------------------------------------------------------------ Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT is a gathering of tech-side developers & brand creativity professionals. Meet the minds behind Google Creative Lab, Visual Complexity, Processing, & iPhoneDevCamp asthey present alongside digital heavyweights like Barbarian Group, R/GA, & Big Spaceship. http://www.creativitycat.com _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
