GetFeatureTypeImpl.getFormatOption returns a shared static map
--------------------------------------------------------------
Key: GEOT-2499
URL: http://jira.codehaus.org/browse/GEOT-2499
Project: GeoTools
Issue Type: Bug
Components: new modules
Affects Versions: 2.5.5
Reporter: Andrea Aime
Assignee: Justin Deoliveira
Fix For: 2.5.6
As reported by M. Leslie in GEOS-3045, GetFeatureTypeImpl.getFormatOptions
returns a map that happens to be the default value, which is a single
statically shared value, so it can be clobbered among requests.
I looked into the code and it seems a mix of generated code and manual
modifications. In particular the static map has been introduced at r31958
manually.
Possible fixes:
- have formatOptions initialized with a new empty map
- follow suit what is done for elists and have format options initialized with
null, and then make the getter check for null and build on the fly an empty map
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, &
iPhoneDevCamp asthey present alongside digital heavyweights like Barbarian
Group, R/GA, & Big Spaceship. http://www.creativitycat.com
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
