Ben Caradoc-Davies ha scritto: > On 29/09/09 10:54, Ben Caradoc-Davies wrote: >> So far, the formal votes I count are +1 (Simone), +0 (me), so it is at >> this time formally accepted. > > Andrea and Christian, do your concerns about unit test coverage in > gt-swing constitute a vote of -1 on promotion to supported? Or do you > vote +1/+0/-0 and recommend future work to improve testability?
It would be a -0. I don't want to stop the good work done so far, I understand the FOSS4G deadlines and I certainly hope the Swing components will be developed further. Making a full test of a GUI (including layout, dynamic behaviour as the user performs certain gestures on the screen, and so on) is a daunting task and it's probably not worth the pain, interactive testing (that is, a human using the GUI) certainly reveals more issues for less effort. Making some minimal testing like prepping the GUI and checking the swing component models contain the expected stuff, check a little validation should not take that much time thought. Here is an example of a test for a keyword editor component in GeoServer: http://svn.codehaus.org/geoserver/trunk/src/web/core/src/test/java/org/geoserver/web/wicket/KeywordsEditorTest.java The test is small but it gives more than enough test coverage to avoid having the GUI break solid without anybody noticing (I think the GS GUI modules have 60%+ coverage) Cheers Andrea -- Andrea Aime OpenGeo - http://opengeo.org Expert service straight from the developers. ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
