> Hum.. a few things are clear by looking at the commit diff anyways:
> - commented out code:
> https://github.com/geotools/geotools/commit/c0fd151d0265aa53b696010d0d995344c6533104#L6R1149
> - given how generics work, isn't this method redundand with respect
> the one right below it?
> https://github.com/geotools/geotools/commit/c0fd151d0265aa53b696010d0d995344c6533104#L6R1277
>
> And also some things that I can see now that I noticed the pull
> request has been updated:
> - several places where the DataUtilities.collectionCast method could
> still be used,
> just look for "throw new IllegalStateException" in the diffs
> provided by github:
> https://github.com/geotools/geotools/pull/44/files
> - in the streamign renderer can't we have a single loop by calling
> DataUtilities.iterator over the
> feature collection, and then calling DataUtiltiies.close(iterator)
> once the loop is done?
> Wouldn't this allow to preserve most of the original code intact?
>
> Cheers
> Andrea
>
> --
> ==
> Our support, Your Success! Visit http://opensdi.geo-solutions.it for
> more information.
> ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via Poggio alle Viti 1187
> 55054 Massarosa (LU)
> Italy
> phone: +39 0584 962313
> fax: +39 0584 1660272
> mob: +39 339 8844549
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> -------------------------------------------------------
------------------------------------------------------------------------------
LogMeIn Central: Instant, anywhere, Remote PC access and management.
Stay in control, update software, and manage PCs from one command center
Diagnose problems and improve visibility into emerging IT issues
Automate, monitor and manage. Do more in less time with Central
http://p.sf.net/sfu/logmein12331_d2d
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
